* [PATCH 0/2] arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO @ 2026-07-16 1:28 Jiaxing Hu 2026-07-16 1:28 ` [PATCH 1/2] dt-bindings: arm: " Jiaxing Hu 2026-07-16 1:28 ` [PATCH 2/2] arm64: dts: " Jiaxing Hu 0 siblings, 2 replies; 7+ messages in thread From: Jiaxing Hu @ 2026-07-16 1:28 UTC (permalink / raw) To: linux-rockchip Cc: heiko, robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel, linux-kernel Add mainline support for the ArmSoM CM5, an RK3576 compute module, and its CM5-IO carrier board. Patch 1 adds the binding, patch 2 the module dtsi and the carrier dts. The on-module YT8531 PHY has no crystal and needs the SoC 25 MHz reference clock (clk_mac_refout). Enabling it for RGMII needs a small dwmac-rk change sent separately to netdev [1]; the clock is optional so this DTS applies without it. Tested on a CM5-IO: the YT8531 link comes up at 1Gbps, and RK806, HYM8563, eMMC, microSD, the USB3 hub and PCIe all probe. [1] net: stmmac: dwmac-rk: enable the reference clock for output mode Jiaxing Hu (2): dt-bindings: arm: rockchip: Add ArmSoM CM5 and CM5-IO arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO .../devicetree/bindings/arm/rockchip.yaml | 7 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../dts/rockchip/rk3576-armsom-cm5-io.dts | 414 +++++++++++++ .../boot/dts/rockchip/rk3576-armsom-cm5.dtsi | 576 ++++++++++++++++++ 4 files changed, 998 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5.dtsi -- 2.43.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] dt-bindings: arm: rockchip: Add ArmSoM CM5 and CM5-IO 2026-07-16 1:28 [PATCH 0/2] arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO Jiaxing Hu @ 2026-07-16 1:28 ` Jiaxing Hu 2026-07-16 8:23 ` Krzysztof Kozlowski 2026-07-16 1:28 ` [PATCH 2/2] arm64: dts: " Jiaxing Hu 1 sibling, 1 reply; 7+ messages in thread From: Jiaxing Hu @ 2026-07-16 1:28 UTC (permalink / raw) To: linux-rockchip Cc: heiko, robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel, linux-kernel Add compatibles for the ArmSoM CM5, an RK3576 compute module, and its CM5-IO carrier board. Signed-off-by: Jiaxing Hu <huhuvmb88@gmail.com> --- Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index 1a9dde186..5c7697f4d 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -71,6 +71,13 @@ properties: - const: ariaboard,photonicat - const: rockchip,rk3568 + - description: ArmSoM CM5 Module based boards + items: + - enum: + - armsom,cm5-io + - const: armsom,cm5 + - const: rockchip,rk3576 + - description: ArmSoM Sige1 board items: - const: armsom,sige1 -- 2.43.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: rockchip: Add ArmSoM CM5 and CM5-IO 2026-07-16 1:28 ` [PATCH 1/2] dt-bindings: arm: " Jiaxing Hu @ 2026-07-16 8:23 ` Krzysztof Kozlowski 0 siblings, 0 replies; 7+ messages in thread From: Krzysztof Kozlowski @ 2026-07-16 8:23 UTC (permalink / raw) To: Jiaxing Hu Cc: linux-rockchip, heiko, robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel, linux-kernel On Thu, Jul 16, 2026 at 01:28:37PM +1200, Jiaxing Hu wrote: > Add compatibles for the ArmSoM CM5, an RK3576 compute module, and its > CM5-IO carrier board. > > Signed-off-by: Jiaxing Hu <huhuvmb88@gmail.com> > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO 2026-07-16 1:28 [PATCH 0/2] arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO Jiaxing Hu 2026-07-16 1:28 ` [PATCH 1/2] dt-bindings: arm: " Jiaxing Hu @ 2026-07-16 1:28 ` Jiaxing Hu 2026-07-16 1:40 ` sashiko-bot 2026-07-16 8:23 ` Krzysztof Kozlowski 1 sibling, 2 replies; 7+ messages in thread From: Jiaxing Hu @ 2026-07-16 1:28 UTC (permalink / raw) To: linux-rockchip Cc: heiko, robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel, linux-kernel Add the ArmSoM CM5, an RK3576 compute module (rk3576-armsom-cm5.dtsi), and its CM5-IO carrier (rk3576-armsom-cm5-io.dts). The module has the RK806 PMIC, HYM8563 RTC, eMMC, GMAC0 with an on-module YT8531 PHY and a SYN43752 WiFi/BT combo; the carrier adds HDMI, GbE, a USB3 hub, USB-C with FUSB302, PCIe, microSD, ES8388 audio, LEDs and a 40-pin header. The YT8531 has no crystal, so it uses the SoC 25 MHz clk_mac_refout output and is reset from the MAC before the MDIO scan. Signed-off-by: Jiaxing Hu <huhuvmb88@gmail.com> --- arch/arm64/boot/dts/rockchip/Makefile | 1 + .../dts/rockchip/rk3576-armsom-cm5-io.dts | 414 +++++++++++++ .../boot/dts/rockchip/rk3576-armsom-cm5.dtsi | 576 ++++++++++++++++++ 3 files changed, 991 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5.dtsi diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile index cb55c6b70..3ec0b6e20 100644 --- a/arch/arm64/boot/dts/rockchip/Makefile +++ b/arch/arm64/boot/dts/rockchip/Makefile @@ -165,6 +165,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-display-vz.dtbo dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-io-expander.dtbo dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-100ask-dshanpi-a1.dtb +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-armsom-cm5-io.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-armsom-sige5.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-armsom-sige5-v1.2-wifibt.dtbo dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-evb1-v10.dtb diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts new file mode 100644 index 000000000..de05e20dc --- /dev/null +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts @@ -0,0 +1,414 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * ArmSoM CM5-IO - official carrier board for the ArmSoM CM5 (RK3576) module. + * + * Carrier provides: + * - Full-size HDMI 2.1 (HDMI TX via HDPTX PHY) + * - Gigabit Ethernet RJ45 (GMAC0 + on-module YT8531) + * - 2x USB-A behind a USB3 hub (combphy1 + u2phy1) + * - USB-C with PD/altmode (FUSB302 on i2c0, combphy0 + USBDP PHY) + * - M.2 PCIe 2.0 x1 slot (combphy0 as PCIe lane) + * - microSD card slot + * - ES8388 audio codec on i2c0 + * - Green/red status LEDs, 40-pin RPi-compatible header + * - 12 V DC barrel jack + * + * Copyright (c) 2024 ArmSoM + * Copyright (c) 2026 Jiaxing Hu <huhuvmb88@gmail.com> + */ + +/dts-v1/; + +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/leds/common.h> +#include <dt-bindings/pinctrl/rockchip.h> +#include <dt-bindings/soc/rockchip,vop2.h> +#include <dt-bindings/usb/pd.h> +#include "rk3576-armsom-cm5.dtsi" + +/ { + model = "ArmSoM CM5-IO"; + compatible = "armsom,cm5-io", "armsom,cm5", "rockchip,rk3576"; + + aliases { + ethernet0 = &gmac0; + mmc0 = &sdhci; + mmc1 = &sdmmc; + }; + + chosen { + stdout-path = "serial0:1500000n8"; + }; + + /* Full-size HDMI Type-A connector, driven by the SoC HDMI TX. */ + hdmi-con { + compatible = "hdmi-connector"; + type = "a"; + + port { + hdmi_con_in: endpoint { + remote-endpoint = <&hdmi_out_con>; + }; + }; + }; + + /* + * Carrier status LEDs (schematic ARMSOM-CM5-IO-1V1_20240829): + * green - GPIO2 PD0 (net LED_GREEN_EN) + * red - GPIO2 PD1 (net LED_RED_EN) + */ + leds: leds { + compatible = "gpio-leds"; + + led_green: led-green { + color = <LED_COLOR_ID_GREEN>; + function = LED_FUNCTION_STATUS; + gpios = <&gpio2 RK_PD0 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&led_green_en>; + default-state = "on"; + }; + + led_red: led-red { + color = <LED_COLOR_ID_RED>; + function = LED_FUNCTION_FAULT; + gpios = <&gpio2 RK_PD1 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&led_red_en>; + default-state = "off"; + }; + }; + + /* Carrier power tree: 12 V barrel jack -> 5 V -> peripheral rails. */ + vcc_12v0_dcin: regulator-vcc-12v0-dcin { + compatible = "regulator-fixed"; + regulator-name = "vcc_12v0_dcin"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <12000000>; + regulator-max-microvolt = <12000000>; + }; + + vcc_5v0_sys: regulator-vcc-5v0-sys { + compatible = "regulator-fixed"; + regulator-name = "vcc_5v0_sys"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + vin-supply = <&vcc_12v0_dcin>; + }; + + vcc_5v0_device: regulator-vcc-5v0-device { + compatible = "regulator-fixed"; + regulator-name = "vcc_5v0_device"; + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + vin-supply = <&vcc_12v0_dcin>; + }; + + /* PCIe 3.3 V for the M.2 slot, gated by GPIO0 PC3. */ + vcc_3v3_pcie: regulator-vcc-3v3-pcie { + compatible = "regulator-fixed"; + pinctrl-names = "default"; + pinctrl-0 = <&pcie_pwr_en>; + regulator-name = "vcc_3v3_pcie"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + enable-active-high; + gpio = <&gpio0 RK_PC3 GPIO_ACTIVE_HIGH>; + startup-delay-us = <5000>; + vin-supply = <&vcc_5v0_sys>; + }; + + /* USB-C / OTG 5 V, gated by GPIO2 PB6. */ + vcc_5v0_typec0: regulator-vcc-5v0-typec0 { + compatible = "regulator-fixed"; + enable-active-high; + gpios = <&gpio2 RK_PB6 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&usb_otg0_pwren>; + regulator-name = "vcc_5v0_typec0"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + vin-supply = <&vcc_5v0_device>; + }; + + /* USB-A host 5 V (through the hub), gated by GPIO4 PB0. */ + vcc_5v0_usbhost: regulator-vcc-5v0-usbhost { + compatible = "regulator-fixed"; + enable-active-high; + gpios = <&gpio4 RK_PB0 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&usb_host_pwren>; + regulator-name = "vcc_5v0_usbhost"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + vin-supply = <&vcc_5v0_device>; + }; +}; + +/* + * ComboPHY0 -> PCIe lane (M.2 slot); ComboPHY1 -> USB3 lane (USB-A hub). + */ +&combphy0_ps { + status = "okay"; +}; + +&combphy1_psu { + status = "okay"; +}; + +&hdmi { + status = "okay"; +}; + +&hdmi_in { + hdmi_in_vp0: endpoint { + remote-endpoint = <&vp0_out_hdmi>; + }; +}; + +&hdmi_out { + hdmi_out_con: endpoint { + remote-endpoint = <&hdmi_con_in>; + }; +}; + +&hdmi_sound { + status = "okay"; +}; + +&hdptxphy { + status = "okay"; +}; + +/* + * I2C0: ES8388 audio codec @ 0x10, FUSB302 USB-C PD controller @ 0x22. + * Pinctrl i2c0m1 (GPIO0 PC4 SCL / GPIO0 PC5 SDA). + */ +&i2c0 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&i2c0m1_xfer>; + + es8388: es8388@10 { + #sound-dai-cells = <0>; + compatible = "everest,es8388", "everest,es8323"; + reg = <0x10>; + pinctrl-names = "default"; + pinctrl-0 = <&sai1m0_mclk>; + status = "disabled"; + }; + + usbc0: fusb302@22 { + compatible = "fcs,fusb302"; + reg = <0x22>; + interrupt-parent = <&gpio0>; + interrupts = <RK_PB4 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names = "default"; + pinctrl-0 = <&usbc0_int>; + vbus-supply = <&vcc_5v0_typec0>; + status = "okay"; + + port { + usbc0_role_sw: endpoint { + remote-endpoint = <&usb_drd0_role_switch>; + }; + }; + + usb_con: connector { + compatible = "usb-c-connector"; + label = "USB-C"; + data-role = "dual"; + power-role = "dual"; + try-power-role = "sink"; + op-sink-microwatt = <1000000>; + sink-pdos = + <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM) + PDO_FIXED(9000, 3000, PDO_FIXED_USB_COMM) + PDO_FIXED(12000, 3000, PDO_FIXED_USB_COMM)>; + source-pdos = + <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>; + + altmodes { + #address-cells = <1>; + #size-cells = <0>; + + altmode@0 { + reg = <0>; + svid = <0xff01>; + vdo = <0xffffffff>; + }; + }; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + usbc0_orien_sw: endpoint { + remote-endpoint = <&usbdp_phy_orientation_switch>; + }; + }; + + port@1 { + reg = <1>; + dp_altmode_mux: endpoint { + remote-endpoint = <&usbdp_phy_dp_altmode_mux>; + }; + }; + }; + }; + }; +}; + +/* + * PCIe 2.0 x1 M.2 slot. Reset GPIO2 PB1, power vcc_3v3_pcie (GPIO0 PC3). + */ +&pcie0 { + pinctrl-names = "default"; + pinctrl-0 = <&pcie_reset>; + reset-gpios = <&gpio2 RK_PB1 GPIO_ACTIVE_HIGH>; + vpcie3v3-supply = <&vcc_3v3_pcie>; + status = "okay"; +}; + +/* microSD card slot. */ +&sdmmc { + bus-width = <4>; + cap-mmc-highspeed; + cap-sd-highspeed; + disable-wp; + max-frequency = <200000000>; + no-sdio; + no-mmc; + sd-uhs-sdr104; + vmmc-supply = <&vcc_3v3_s3>; + vqmmc-supply = <&vccio_sd_s0>; + status = "okay"; +}; + +&u2phy0 { + status = "okay"; +}; + +&u2phy0_otg { + phy-supply = <&vcc_5v0_typec0>; + status = "okay"; +}; + +&u2phy1 { + status = "okay"; +}; + +&u2phy1_otg { + phy-supply = <&vcc_5v0_usbhost>; + status = "okay"; +}; + +/* Debug UART0 on the 40-pin header. */ +&uart0 { + pinctrl-0 = <&uart0m0_xfer>; + status = "okay"; +}; + +/* USB DRD0: USB-C (USBDP SuperSpeed + USB2 HS), OTG with FUSB302 role-switch. */ +&usb_drd0_dwc3 { + dr_mode = "otg"; + usb-role-switch; + status = "okay"; + + port { + usb_drd0_role_switch: endpoint { + remote-endpoint = <&usbc0_role_sw>; + }; + }; +}; + +/* USB DRD1: USB-A ports behind the hub (combphy1 SuperSpeed + USB2 HS). */ +&usb_drd1_dwc3 { + dr_mode = "host"; + status = "okay"; +}; + +&usbdp_phy { + status = "okay"; + orientation-switch; + svid = <0xff01>; + sbu1-dc-gpios = <&gpio4 RK_PC4 GPIO_ACTIVE_HIGH>; + sbu2-dc-gpios = <&gpio4 RK_PC5 GPIO_ACTIVE_HIGH>; + + port { + #address-cells = <1>; + #size-cells = <0>; + + usbdp_phy_orientation_switch: endpoint@0 { + reg = <0>; + remote-endpoint = <&usbc0_orien_sw>; + }; + + usbdp_phy_dp_altmode_mux: endpoint@1 { + reg = <1>; + remote-endpoint = <&dp_altmode_mux>; + }; + }; +}; + +&vop { + status = "okay"; +}; + +&vop_mmu { + status = "okay"; +}; + +&vp0 { + vp0_out_hdmi: endpoint@ROCKCHIP_VOP2_EP_HDMI0 { + reg = <ROCKCHIP_VOP2_EP_HDMI0>; + remote-endpoint = <&hdmi_in_vp0>; + }; +}; + +&pinctrl { + leds { + /* GPIO2 PD0 - green carrier LED */ + led_green_en: led-green-en { + rockchip,pins = <2 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>; + }; + + /* GPIO2 PD1 - red carrier LED */ + led_red_en: led-red-en { + rockchip,pins = <2 RK_PD1 RK_FUNC_GPIO &pcfg_pull_none>; + }; + }; + + pcie { + /* GPIO0 PC3 - PCIe power enable */ + pcie_pwr_en: pcie-pwr-en { + rockchip,pins = <0 RK_PC3 RK_FUNC_GPIO &pcfg_pull_down>; + }; + /* GPIO2 PB1 - PCIe PERST# */ + pcie_reset: pcie-reset { + rockchip,pins = <2 RK_PB1 RK_FUNC_GPIO &pcfg_pull_up>; + }; + }; + + usb { + /* GPIO4 PB0 - USB host 5V enable */ + usb_host_pwren: usb-host-pwren { + rockchip,pins = <4 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>; + }; + /* GPIO2 PB6 - USB OTG / Type-C 5V enable */ + usb_otg0_pwren: usb-otg0-pwren { + rockchip,pins = <2 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>; + }; + /* GPIO0 PB4 - FUSB302 INT# (active-low) */ + usbc0_int: usbc0-int { + rockchip,pins = <0 RK_PB4 RK_FUNC_GPIO &pcfg_pull_up>; + }; + }; +}; diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5.dtsi b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5.dtsi new file mode 100644 index 000000000..983b3e72c --- /dev/null +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5.dtsi @@ -0,0 +1,576 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * ArmSoM CM5 - Rockchip RK3576 compute module (Raspberry Pi CM4 form factor). + * + * Common to all CM5 carriers. The carrier .dts includes this file, sets the + * board model/compatible, and adds carrier-specific peripherals. + * + * On-module devices: + * - RK806 PMIC on I2C1 + * - HYM8563 RTC on I2C2 + * - eMMC (SDHCI) + * - GMAC0 + MotorComm YT8531 Gigabit Ethernet PHY (RGMII) + * - SYN43752 WiFi 6 + BT 5.x (SDIO + UART4) + * + * Copyright (c) 2024 ArmSoM + * Copyright (c) 2026 Jiaxing Hu <huhuvmb88@gmail.com> + */ + +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/pinctrl/rockchip.h> +#include "rk3576.dtsi" + +/ { + compatible = "armsom,cm5", "rockchip,rk3576"; + + vcc_1v1_nldo_s3: regulator-vcc-1v1-nldo-s3 { + compatible = "regulator-fixed"; + regulator-name = "vcc_1v1_nldo_s3"; + regulator-boot-on; + regulator-always-on; + regulator-min-microvolt = <1100000>; + regulator-max-microvolt = <1100000>; + vin-supply = <&vcc_5v0_sys>; + }; + + vcc_1v2_ufs_vccq_s0: regulator-vcc-1v2-ufs-vccq-s0 { + compatible = "regulator-fixed"; + regulator-name = "vcc_1v2_ufs_vccq_s0"; + regulator-boot-on; + regulator-always-on; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + vin-supply = <&vcc_5v0_sys>; + }; + + vcc_1v8_s0: regulator-vcc-1v8-s0 { + compatible = "regulator-fixed"; + regulator-name = "vcc_1v8_s0"; + regulator-boot-on; + regulator-always-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + vin-supply = <&vcc_1v8_s3>; + }; + + vcc_1v8_ufs_vccq2_s0: regulator-vcc-1v8-ufs-vccq2-s0 { + compatible = "regulator-fixed"; + regulator-name = "vcc_1v8_ufs_vccq2_s0"; + regulator-boot-on; + regulator-always-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + vin-supply = <&vcc_1v8_s3>; + }; + + vcc_2v0_pldo_s3: regulator-vcc-2v0-pldo-s3 { + compatible = "regulator-fixed"; + regulator-name = "vcc_2v0_pldo_s3"; + regulator-boot-on; + regulator-always-on; + regulator-min-microvolt = <2000000>; + regulator-max-microvolt = <2000000>; + vin-supply = <&vcc_5v0_sys>; + }; + + vcc_3v3_s0: regulator-vcc-3v3-s0 { + compatible = "regulator-fixed"; + regulator-name = "vcc_3v3_s0"; + regulator-boot-on; + regulator-always-on; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + vin-supply = <&vcc_3v3_s3>; + }; + + vcc_3v3_ufs_s0: regulator-vcc-ufs-s0 { + compatible = "regulator-fixed"; + regulator-name = "vcc_3v3_ufs_s0"; + regulator-boot-on; + regulator-always-on; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + vin-supply = <&vcc_5v0_sys>; + }; + + /* + * WiFi power sequencer for SYN43752. Reset GPIO1 PC6 active-low, + * clock from the HYM8563 RTC oscillator. + */ + sdio_pwrseq: sdio-pwrseq { + compatible = "mmc-pwrseq-simple"; + clocks = <&hym8563>; + clock-names = "ext_clock"; + pinctrl-names = "default"; + pinctrl-0 = <&wifi_poweren_gpio>; + reset-gpios = <&gpio1 RK_PC6 GPIO_ACTIVE_LOW>; + }; +}; + +&cpu_b0 { + cpu-supply = <&vdd_cpu_big_s0>; +}; + +&cpu_b1 { + cpu-supply = <&vdd_cpu_big_s0>; +}; + +&cpu_b2 { + cpu-supply = <&vdd_cpu_big_s0>; +}; + +&cpu_b3 { + cpu-supply = <&vdd_cpu_big_s0>; +}; + +&cpu_l0 { + cpu-supply = <&vdd_cpu_lit_s0>; +}; + +&cpu_l1 { + cpu-supply = <&vdd_cpu_lit_s0>; +}; + +&cpu_l2 { + cpu-supply = <&vdd_cpu_lit_s0>; +}; + +&cpu_l3 { + cpu-supply = <&vdd_cpu_lit_s0>; +}; + +/* + * GMAC0 + on-module MotorComm YT8531 in rgmii-rxid mode (MAC TX delay 0x21, + * PHY does RX delay). The YT8531 has NO local crystal, so it relies on the + * SoC 25 MHz reference: clk_mac_refout (= REFCLKO25M_GMAC0_OUT) must be listed + * on the gmac node - dwmac-rk only enables/routes it when named here - and the + * ethm0_clk0_25m_out pin routes it to the pad. PHY reset via the MAC + * (snps,reset) so stmmac releases it before the MDIO scan. + */ +&gmac0 { + phy-mode = "rgmii-rxid"; + clock_in_out = "output"; + clocks = <&cru CLK_GMAC0_125M_SRC>, <&cru CLK_GMAC0_RMII_CRU>, + <&cru PCLK_GMAC0>, <&cru ACLK_GMAC0>, + <&cru CLK_GMAC0_PTP_REF>, <&cru REFCLKO25M_GMAC0_OUT>; + clock-names = "stmmaceth", "clk_mac_ref", "pclk_mac", "aclk_mac", + "ptp_ref", "clk_mac_refout"; + tx_delay = <0x21>; + rx_delay = <0x00>; + phy-handle = <&rgmii_phy0>; + phy-supply = <&vcc_3v3_s3>; + snps,reset-gpios = <&gpio2 RK_PB3 GPIO_ACTIVE_LOW>; + snps,reset-delays-us = <0 20000 100000>; + pinctrl-names = "default"; + pinctrl-0 = <ð0m0_miim + ð0m0_tx_bus2 + ð0m0_rx_bus2 + ð0m0_rgmii_clk + ð0m0_rgmii_bus + ðm0_clk0_25m_out>; + status = "okay"; +}; + +&gpu { + mali-supply = <&vdd_gpu_s0>; + status = "okay"; +}; + +/* I2C1: RK806 PMIC @ 0x23 (interrupt on GPIO0 PA6). */ +&i2c1 { + status = "okay"; + + pmic@23 { + compatible = "rockchip,rk806"; + reg = <0x23>; + + interrupt-parent = <&gpio0>; + interrupts = <RK_PA6 IRQ_TYPE_LEVEL_LOW>; + + pinctrl-names = "default"; + pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>, + <&rk806_dvs2_null>, <&rk806_dvs3_null>; + + system-power-controller; + + vcc1-supply = <&vcc_5v0_sys>; + vcc2-supply = <&vcc_5v0_sys>; + vcc3-supply = <&vcc_5v0_sys>; + vcc4-supply = <&vcc_5v0_sys>; + vcc5-supply = <&vcc_5v0_sys>; + vcc6-supply = <&vcc_5v0_sys>; + vcc7-supply = <&vcc_5v0_sys>; + vcc8-supply = <&vcc_5v0_sys>; + vcc9-supply = <&vcc_5v0_sys>; + vcc10-supply = <&vcc_5v0_sys>; + vcc11-supply = <&vcc_2v0_pldo_s3>; + vcc12-supply = <&vcc_5v0_sys>; + vcc13-supply = <&vcc_1v1_nldo_s3>; + vcc14-supply = <&vcc_1v1_nldo_s3>; + vcca-supply = <&vcc_5v0_sys>; + + gpio-controller; + #gpio-cells = <2>; + + rk806_dvs1_null: dvs1-null-pins { + pins = "gpio_pwrctrl1"; + function = "pin_fun0"; + }; + + rk806_dvs2_null: dvs2-null-pins { + pins = "gpio_pwrctrl2"; + function = "pin_fun0"; + }; + + rk806_dvs3_null: dvs3-null-pins { + pins = "gpio_pwrctrl3"; + function = "pin_fun0"; + }; + + regulators { + vdd_cpu_big_s0: dcdc-reg1 { + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <550000>; + regulator-max-microvolt = <950000>; + regulator-ramp-delay = <12500>; + regulator-name = "vdd_cpu_big_s0"; + regulator-enable-ramp-delay = <400>; + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + vdd_npu_s0: dcdc-reg2 { + regulator-boot-on; + regulator-min-microvolt = <550000>; + regulator-max-microvolt = <950000>; + regulator-ramp-delay = <12500>; + regulator-name = "vdd_npu_s0"; + regulator-enable-ramp-delay = <400>; + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + vdd_cpu_lit_s0: dcdc-reg3 { + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <550000>; + regulator-max-microvolt = <950000>; + regulator-ramp-delay = <12500>; + regulator-name = "vdd_cpu_lit_s0"; + regulator-state-mem { + regulator-off-in-suspend; + regulator-suspend-microvolt = <750000>; + }; + }; + + vcc_3v3_s3: dcdc-reg4 { + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-name = "vcc_3v3_s3"; + regulator-state-mem { + regulator-on-in-suspend; + regulator-suspend-microvolt = <3300000>; + }; + }; + + vdd_gpu_s0: dcdc-reg5 { + regulator-boot-on; + regulator-min-microvolt = <550000>; + regulator-max-microvolt = <900000>; + regulator-ramp-delay = <12500>; + regulator-name = "vdd_gpu_s0"; + regulator-enable-ramp-delay = <400>; + regulator-state-mem { + regulator-off-in-suspend; + regulator-suspend-microvolt = <850000>; + }; + }; + + vddq_ddr_s0: dcdc-reg6 { + regulator-always-on; + regulator-boot-on; + regulator-name = "vddq_ddr_s0"; + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + vdd_logic_s0: dcdc-reg7 { + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <550000>; + regulator-max-microvolt = <800000>; + regulator-name = "vdd_logic_s0"; + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + vcc_1v8_s3: dcdc-reg8 { + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-name = "vcc_1v8_s3"; + regulator-state-mem { + regulator-on-in-suspend; + regulator-suspend-microvolt = <1800000>; + }; + }; + + vdd2_ddr_s3: dcdc-reg9 { + regulator-always-on; + regulator-boot-on; + regulator-name = "vdd2_ddr_s3"; + regulator-state-mem { + regulator-on-in-suspend; + }; + }; + + vdd_ddr_s0: dcdc-reg10 { + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <550000>; + regulator-max-microvolt = <1200000>; + regulator-name = "vdd_ddr_s0"; + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + vcca_1v8_s0: pldo-reg1 { + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-name = "vcca_1v8_s0"; + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + vcca1v8_pldo2_s0: pldo-reg2 { + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-name = "vcca1v8_pldo2_s0"; + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + vdda_1v2_s0: pldo-reg3 { + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + regulator-name = "vdda_1v2_s0"; + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + vcca_3v3_s0: pldo-reg4 { + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-name = "vcca_3v3_s0"; + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + vccio_sd_s0: pldo-reg5 { + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + regulator-name = "vccio_sd_s0"; + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + vcca1v8_pldo6_s3: pldo-reg6 { + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-name = "vcca1v8_pldo6_s3"; + regulator-state-mem { + regulator-on-in-suspend; + regulator-suspend-microvolt = <1800000>; + }; + }; + + vdd_0v75_s3: nldo-reg1 { + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <750000>; + regulator-max-microvolt = <750000>; + regulator-name = "vdd_0v75_s3"; + regulator-state-mem { + regulator-on-in-suspend; + regulator-suspend-microvolt = <750000>; + }; + }; + + vdda_ddr_pll_s0: nldo-reg2 { + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <850000>; + regulator-max-microvolt = <850000>; + regulator-name = "vdda_ddr_pll_s0"; + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + vdda0v75_hdmi_s0: nldo-reg3 { + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <837500>; + regulator-max-microvolt = <837500>; + regulator-name = "vdda0v75_hdmi_s0"; + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + vdda_0v85_s0: nldo-reg4 { + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <850000>; + regulator-max-microvolt = <850000>; + regulator-name = "vdda_0v85_s0"; + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + + vdda_0v75_s0: nldo-reg5 { + regulator-always-on; + regulator-boot-on; + regulator-min-microvolt = <750000>; + regulator-max-microvolt = <750000>; + regulator-name = "vdda_0v75_s0"; + regulator-state-mem { + regulator-off-in-suspend; + }; + }; + }; + }; +}; + +/* I2C2: HYM8563 RTC @ 0x51 (interrupt on GPIO0 PA0). */ +&i2c2 { + status = "okay"; + + hym8563: rtc@51 { + compatible = "haoyu,hym8563"; + reg = <0x51>; + clock-output-names = "hym8563"; + interrupt-parent = <&gpio0>; + interrupts = <RK_PA0 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names = "default"; + pinctrl-0 = <&hym8563_int>; + wakeup-source; + #clock-cells = <0>; + }; +}; + +&mdio0 { + rgmii_phy0: phy@1 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <0x1>; + clocks = <&cru REFCLKO25M_GMAC0_OUT>; + assigned-clocks = <&cru REFCLKO25M_GMAC0_OUT>; + assigned-clock-rates = <25000000>; + }; +}; + +&saradc { + vref-supply = <&vcca_1v8_s0>; + status = "okay"; +}; + +/* eMMC: on-module, HS400 200 MHz with enhanced strobe. */ +&sdhci { + bus-width = <8>; + full-pwr-cycle-in-suspend; + max-frequency = <200000000>; + mmc-hs400-1_8v; + mmc-hs400-enhanced-strobe; + no-sdio; + no-sd; + non-removable; + /delete-property/ supports-cqe; + status = "okay"; +}; + +/* SDIO: SYN43752 WiFi, power-sequenced by sdio_pwrseq, clock from HYM8563. */ +&sdio { + bus-width = <4>; + cap-sdio-irq; + disable-wp; + keep-power-in-suspend; + mmc-pwrseq = <&sdio_pwrseq>; + no-sd; + no-mmc; + non-removable; + sd-uhs-sdr50; + sd-uhs-sdr104; + vmmc-supply = <&vcc_3v3_s3>; + vqmmc-supply = <&vcc_1v8_s3>; + wakeup-source; + status = "okay"; +}; + +/* UART4: Bluetooth (SYN43752). */ +&uart4 { + pinctrl-0 = <&uart4m1_xfer &uart4m1_ctsn &uart4m1_rtsn>; + pinctrl-names = "default"; + uart-has-rtscts; + status = "okay"; +}; + +&pinctrl { + gmac { + /* GPIO2 PB3 - GMAC0 PHY reset (active-low) */ + gmac0_rst: gmac0-rst { + rockchip,pins = <2 RK_PB3 RK_FUNC_GPIO &pcfg_pull_none>; + }; + }; + + hym8563 { + hym8563_int: hym8563-int { + rockchip,pins = <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_up>; + }; + }; + + wireless-bluetooth { + /* GPIO1 PC7 - BT reset / enable (active-high) */ + bt_reg_on: bt-reg-on { + rockchip,pins = <1 RK_PC7 RK_FUNC_GPIO &pcfg_pull_up>; + }; + }; + + wireless-wlan { + /* GPIO0 PB0 - WiFi wake host interrupt (SDIO IRQ) */ + wifi_host_wake_irq: wifi-host-wake-irq { + rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_down>; + }; + + /* GPIO1 PC6 - WiFi power enable / reset (sdio_pwrseq) */ + wifi_poweren_gpio: wifi-poweren-gpio { + rockchip,pins = <1 RK_PC6 RK_FUNC_GPIO &pcfg_pull_up>; + }; + }; +}; -- 2.43.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO 2026-07-16 1:28 ` [PATCH 2/2] arm64: dts: " Jiaxing Hu @ 2026-07-16 1:40 ` sashiko-bot 2026-07-16 6:55 ` Jiaxing Hu 2026-07-16 8:23 ` Krzysztof Kozlowski 1 sibling, 1 reply; 7+ messages in thread From: sashiko-bot @ 2026-07-16 1:40 UTC (permalink / raw) To: Jiaxing Hu; +Cc: conor+dt, devicetree, robh Thank you for your contribution! Sashiko AI review found 5 potential issue(s) to consider: - [High] Type-C DP Altmode configuration errors (SVID format, missing mode-switch, and misplaced SVID) - [High] Wireless (SYN43752 WiFi/BT) missing child nodes and unreferenced pinctrls - [Medium] ES8388 audio is advertised in the commit message but functionally missing - [Medium] Missing vmmc-supply and vqmmc-supply for the eMMC - [Low] The gmac0_rst pinctrl is defined but omitted from &gmac0 -- --- Patch [2]: [PATCH 2/2] arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO --- commit 0ff6fbd7a765dd8a49516e69aa071bce9122a7bd Author: Jiaxing Hu <huhuvmb88@gmail.com> arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO Adds the RK3576-based ArmSoM CM5 compute module and its CM5-IO carrier board. This includes support for the RK806 PMIC, HYM8563 RTC, eMMC, GMAC, SYN43752 WiFi/BT, HDMI, PCIe, and USB. > diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts > new file mode 100644 > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts [ ... ] > +&i2c0 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c0m1_xfer>; > + > + es8388: es8388@10 { > + #sound-dai-cells = <0>; > + compatible = "everest,es8388", "everest,es8323"; > + reg = <0x10>; > + pinctrl-names = "default"; > + pinctrl-0 = <&sai1m0_mclk>; > + status = "disabled"; > + }; [Severity: Medium] The commit message mentions adding ES8388 audio support, but the node is explicitly set to disabled here. Is this board missing a sound card node (like simple-audio-card) or I2S integration to make the audio codec functionally available? [ ... ] > + altmodes { > + #address-cells = <1>; > + #size-cells = <0>; > + > + altmode@0 { > + reg = <0>; > + svid = <0xff01>; [Severity: High] Does this property format result in a 32-bit property being created? When fwnode_property_read_u16() reads this, it will extract the first two bytes, which might evaluate to an invalid SVID of 0 rather than 0xff01. Should this be specified as a 16-bit property, such as: svid = /bits/ 16 <0xff01>; > + vdo = <0xffffffff>; > + }; > + }; [ ... ] > +&usbdp_phy { > + status = "okay"; > + orientation-switch; > + svid = <0xff01>; > + sbu1-dc-gpios = <&gpio4 RK_PC4 GPIO_ACTIVE_HIGH>; > + sbu2-dc-gpios = <&gpio4 RK_PC5 GPIO_ACTIVE_HIGH>; [Severity: High] Does the Rockchip USB/DP PHY driver expect an svid property at this level? Also, is this node missing the mode-switch; boolean property? Without it, the PHY driver might fail to register as a Type-C mux, preventing DP Altmode from negotiating successfully. > + > + port { > + #address-cells = <1>; > + #size-cells = <0>; [ ... ] > diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5.dtsi b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5.dtsi > new file mode 100644 > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5.dtsi [ ... ] > +&gmac0 { > + phy-mode = "rgmii-rxid"; > + clock_in_out = "output"; > + clocks = <&cru CLK_GMAC0_125M_SRC>, <&cru CLK_GMAC0_RMII_CRU>, > + <&cru PCLK_GMAC0>, <&cru ACLK_GMAC0>, > + <&cru CLK_GMAC0_PTP_REF>, <&cru REFCLKO25M_GMAC0_OUT>; > + clock-names = "stmmaceth", "clk_mac_ref", "pclk_mac", "aclk_mac", > + "ptp_ref", "clk_mac_refout"; > + tx_delay = <0x21>; > + rx_delay = <0x00>; > + phy-handle = <&rgmii_phy0>; > + phy-supply = <&vcc_3v3_s3>; > + snps,reset-gpios = <&gpio2 RK_PB3 GPIO_ACTIVE_LOW>; > + snps,reset-delays-us = <0 20000 100000>; > + pinctrl-names = "default"; > + pinctrl-0 = <ð0m0_miim > + ð0m0_tx_bus2 > + ð0m0_rx_bus2 > + ð0m0_rgmii_clk > + ð0m0_rgmii_bus > + ðm0_clk0_25m_out>; [Severity: Low] Is &gmac0_rst missing from this pinctrl-0 list? The gmac0-rst pinctrl is defined later in this file to configure the PHY reset pin without pull resistors. Although snps,reset-gpios drives the pin, missing the pinctrl assignment leaves the configuration as dead code and might result in undefined pin states during boot or sleep. > + status = "okay"; > +}; [ ... ] > +/* eMMC: on-module, HS400 200 MHz with enhanced strobe. */ > +&sdhci { > + bus-width = <8>; > + full-pwr-cycle-in-suspend; > + max-frequency = <200000000>; [Severity: Medium] Are vmmc-supply and vqmmc-supply required for this node? By specifying full-pwr-cycle-in-suspend without defining the regulator supplies, the MMC subsystem cannot actively perform the requested power cycle. This might fall back to a dummy regulator and cause improper suspend/resume behavior. > + mmc-hs400-1_8v; > + mmc-hs400-enhanced-strobe; > + no-sdio; > + no-sd; > + non-removable; > + /delete-property/ supports-cqe; > + status = "okay"; > +}; > + > +/* SDIO: SYN43752 WiFi, power-sequenced by sdio_pwrseq, clock from HYM8563. */ > +&sdio { > + bus-width = <4>; > + cap-sdio-irq; [Severity: High] Is a WiFi child node missing here to configure out-of-band interrupts? Without the child node, the wifi_host_wake_irq pinctrl defined later is unreferenced, which might break host-wake interrupt functionality. > + disable-wp; > + keep-power-in-suspend; > + mmc-pwrseq = <&sdio_pwrseq>; > + no-sd; > + no-mmc; > + non-removable; > + sd-uhs-sdr50; > + sd-uhs-sdr104; > + vmmc-supply = <&vcc_3v3_s3>; > + vqmmc-supply = <&vcc_1v8_s3>; > + wakeup-source; > + status = "okay"; > +}; > + > +/* UART4: Bluetooth (SYN43752). */ > +&uart4 { > + pinctrl-0 = <&uart4m1_xfer &uart4m1_ctsn &uart4m1_rtsn>; > + pinctrl-names = "default"; > + uart-has-rtscts; > + status = "okay"; > +}; [Severity: High] Should there be a bluetooth child node added to this UART configuration? Without it, the Bluetooth driver cannot probe, and the bt_reg_on pinctrl defined below remains unused, preventing the chip from being taken out of reset. [ ... ] -- Sashiko AI review · https://sashiko.dev/#/patchset/20260716012838.2353939-1-huhuvmb88@gmail.com?part=2 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO 2026-07-16 1:40 ` sashiko-bot @ 2026-07-16 6:55 ` Jiaxing Hu 0 siblings, 0 replies; 7+ messages in thread From: Jiaxing Hu @ 2026-07-16 6:55 UTC (permalink / raw) To: sashiko-bot Cc: heiko, robh, krzk+dt, conor+dt, devicetree, linux-rockchip, linux-arm-kernel, linux-kernel (Replying from my own domain; v1 went out as huhuvmb88@gmail.com. Same person, I will use this address from v2 on.) Thanks. Most of this is valid, v2 coming. I ran dtbs_check too; it agrees and finds more. > [High] Type-C DP Altmode configuration errors (SVID format, missing > mode-switch, and misplaced SVID) Correct, and worse. dtbs_check rejects the node: the altmodes child must be named "displayport", not altmode@0 with a reg, and svid must be /bits/ 16. The svid I put on &usbdp_phy is not in that binding at all (it has additionalProperties: false), and mode-switch is missing. > [High] Wireless (SYN43752 WiFi/BT) missing child nodes and unreferenced > pinctrls > [Low] The gmac0_rst pinctrl is defined but omitted from &gmac0 Correct. bt_reg_on, wifi_host_wake_irq and gmac0_rst are all unreferenced. I will drop them rather than guess at wifi/bt child nodes, and drop the WiFi/BT claim from the commit message. > [Medium] ES8388 audio is advertised in the commit message but > functionally missing Correct. The node is disabled and its compatible is wrong too (the binding wants everest,es8328). Dropping the node and the claim. > [Medium] Missing vmmc-supply and vqmmc-supply for the eMMC This one I do not think holds. Every rk3576 board upstream (sige5, evb1/evb2, roc-pc, nanopi-r76s, dshanpi-a1) uses full-pwr-cycle-in-suspend without supplies, and dtbs_check does not flag it. Not in the report, but also fixed in v2: the fusb302 port node is not allowed by its binding (the role-switch endpoint belongs in the connector's ports), and the wifi-poweren-gpio pinctrl node name collides with gpio-consumer. Also the PHY reset. I had it as snps,reset-gpios, which is both misspelled (the schema property is singular) and deprecated. v2 describes it on the MDIO bus instead: &mdio0 { reset-gpios = <&gpio2 RK_PB3 GPIO_ACTIVE_LOW>; reset-delay-us = <20000>; reset-post-delay-us = <100000>; rgmii_phy0: phy@1 { ... }; }; That is the only spelling that works here. __mdiobus_register() releases a bus level reset before mdiobus_scan_bus_c22(), whereas a per-PHY reset-gpios is applied by phylib only after the PHY has been found, which never happens for a PHY that boots held in reset. Checked all three on hardware: per-PHY reset leaves the PHY dark, the bus level reset brings it up and the link comes up at 1000 Mbit/s. dtbs_check is clean on v2, with no deprecated properties left. Jiaxing ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO 2026-07-16 1:28 ` [PATCH 2/2] arm64: dts: " Jiaxing Hu 2026-07-16 1:40 ` sashiko-bot @ 2026-07-16 8:23 ` Krzysztof Kozlowski 1 sibling, 0 replies; 7+ messages in thread From: Krzysztof Kozlowski @ 2026-07-16 8:23 UTC (permalink / raw) To: Jiaxing Hu Cc: linux-rockchip, heiko, robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel, linux-kernel On Thu, Jul 16, 2026 at 01:28:38PM +1200, Jiaxing Hu wrote: > +/* > + * I2C0: ES8388 audio codec @ 0x10, FUSB302 USB-C PD controller @ 0x22. > + * Pinctrl i2c0m1 (GPIO0 PC4 SCL / GPIO0 PC5 SDA). > + */ > +&i2c0 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c0m1_xfer>; > + > + es8388: es8388@10 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation If you cannot find a name matching your device, please check in kernel sources for similar cases or you can grow the spec (via pull request to DT spec repo). > + #sound-dai-cells = <0>; Please order properties according to DTS coding style. > + compatible = "everest,es8388", "everest,es8323"; > + reg = <0x10>; > + pinctrl-names = "default"; > + pinctrl-0 = <&sai1m0_mclk>; > + status = "disabled"; > + }; > + > + usbc0: fusb302@22 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation If you cannot find a name matching your device, please check in kernel sources for similar cases or you can grow the spec (via pull request to DT spec repo). > + compatible = "fcs,fusb302"; > + reg = <0x22>; > + interrupt-parent = <&gpio0>; > + interrupts = <RK_PB4 IRQ_TYPE_LEVEL_LOW>; > + pinctrl-names = "default"; > + pinctrl-0 = <&usbc0_int>; > + vbus-supply = <&vcc_5v0_typec0>; > + status = "okay"; Why? Who disabled it? > + > + port { > + usbc0_role_sw: endpoint { > + remote-endpoint = <&usb_drd0_role_switch>; > + }; > + }; > + > + usb_con: connector { > + compatible = "usb-c-connector"; > + label = "USB-C"; > + data-role = "dual"; > + power-role = "dual"; > + try-power-role = "sink"; > + op-sink-microwatt = <1000000>; > + sink-pdos = > + <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM) > + PDO_FIXED(9000, 3000, PDO_FIXED_USB_COMM) > + PDO_FIXED(12000, 3000, PDO_FIXED_USB_COMM)>; > + source-pdos = > + <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>; > + > + altmodes { > + #address-cells = <1>; > + #size-cells = <0>; > + > + altmode@0 { > + reg = <0>; > + svid = <0xff01>; > + vdo = <0xffffffff>; > + }; > + }; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + usbc0_orien_sw: endpoint { > + remote-endpoint = <&usbdp_phy_orientation_switch>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + dp_altmode_mux: endpoint { > + remote-endpoint = <&usbdp_phy_dp_altmode_mux>; > + }; > + }; > + }; > + }; > + }; > +}; > + > +/* > + * PCIe 2.0 x1 M.2 slot. Reset GPIO2 PB1, power vcc_3v3_pcie (GPIO0 PC3). > + */ > +&pcie0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pcie_reset>; > + reset-gpios = <&gpio2 RK_PB1 GPIO_ACTIVE_HIGH>; > + vpcie3v3-supply = <&vcc_3v3_pcie>; > + status = "okay"; > +}; > + > +/* microSD card slot. */ > +&sdmmc { > + bus-width = <4>; > + cap-mmc-highspeed; > + cap-sd-highspeed; > + disable-wp; > + max-frequency = <200000000>; > + no-sdio; > + no-mmc; > + sd-uhs-sdr104; > + vmmc-supply = <&vcc_3v3_s3>; > + vqmmc-supply = <&vccio_sd_s0>; > + status = "okay"; > +}; > + > +&u2phy0 { > + status = "okay"; > +}; > + > +&u2phy0_otg { > + phy-supply = <&vcc_5v0_typec0>; > + status = "okay"; > +}; > + > +&u2phy1 { > + status = "okay"; > +}; > + > +&u2phy1_otg { > + phy-supply = <&vcc_5v0_usbhost>; > + status = "okay"; > +}; > + > +/* Debug UART0 on the 40-pin header. */ > +&uart0 { > + pinctrl-0 = <&uart0m0_xfer>; > + status = "okay"; > +}; > + > +/* USB DRD0: USB-C (USBDP SuperSpeed + USB2 HS), OTG with FUSB302 role-switch. */ > +&usb_drd0_dwc3 { > + dr_mode = "otg"; > + usb-role-switch; > + status = "okay"; > + > + port { > + usb_drd0_role_switch: endpoint { > + remote-endpoint = <&usbc0_role_sw>; > + }; > + }; > +}; > + > +/* USB DRD1: USB-A ports behind the hub (combphy1 SuperSpeed + USB2 HS). */ > +&usb_drd1_dwc3 { > + dr_mode = "host"; > + status = "okay"; > +}; > + > +&usbdp_phy { > + status = "okay"; > + orientation-switch; > + svid = <0xff01>; > + sbu1-dc-gpios = <&gpio4 RK_PC4 GPIO_ACTIVE_HIGH>; > + sbu2-dc-gpios = <&gpio4 RK_PC5 GPIO_ACTIVE_HIGH>; > + > + port { > + #address-cells = <1>; > + #size-cells = <0>; > + > + usbdp_phy_orientation_switch: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&usbc0_orien_sw>; > + }; > + > + usbdp_phy_dp_altmode_mux: endpoint@1 { > + reg = <1>; > + remote-endpoint = <&dp_altmode_mux>; > + }; > + }; > +}; > + > +&vop { > + status = "okay"; > +}; > + > +&vop_mmu { > + status = "okay"; > +}; > + > +&vp0 { > + vp0_out_hdmi: endpoint@ROCKCHIP_VOP2_EP_HDMI0 { > + reg = <ROCKCHIP_VOP2_EP_HDMI0>; > + remote-endpoint = <&hdmi_in_vp0>; > + }; > +}; > + > +&pinctrl { > + leds { > + /* GPIO2 PD0 - green carrier LED */ > + led_green_en: led-green-en { > + rockchip,pins = <2 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + > + /* GPIO2 PD1 - red carrier LED */ > + led_red_en: led-red-en { > + rockchip,pins = <2 RK_PD1 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > + > + pcie { > + /* GPIO0 PC3 - PCIe power enable */ > + pcie_pwr_en: pcie-pwr-en { > + rockchip,pins = <0 RK_PC3 RK_FUNC_GPIO &pcfg_pull_down>; > + }; > + /* GPIO2 PB1 - PCIe PERST# */ > + pcie_reset: pcie-reset { > + rockchip,pins = <2 RK_PB1 RK_FUNC_GPIO &pcfg_pull_up>; > + }; > + }; > + > + usb { > + /* GPIO4 PB0 - USB host 5V enable */ > + usb_host_pwren: usb-host-pwren { > + rockchip,pins = <4 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + /* GPIO2 PB6 - USB OTG / Type-C 5V enable */ > + usb_otg0_pwren: usb-otg0-pwren { > + rockchip,pins = <2 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + /* GPIO0 PB4 - FUSB302 INT# (active-low) */ > + usbc0_int: usbc0-int { > + rockchip,pins = <0 RK_PB4 RK_FUNC_GPIO &pcfg_pull_up>; > + }; > + }; > +}; > diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5.dtsi b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5.dtsi > new file mode 100644 > index 000000000..983b3e72c > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5.dtsi > @@ -0,0 +1,576 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * ArmSoM CM5 - Rockchip RK3576 compute module (Raspberry Pi CM4 form factor). > + * > + * Common to all CM5 carriers. The carrier .dts includes this file, sets the > + * board model/compatible, and adds carrier-specific peripherals. > + * > + * On-module devices: > + * - RK806 PMIC on I2C1 > + * - HYM8563 RTC on I2C2 > + * - eMMC (SDHCI) > + * - GMAC0 + MotorComm YT8531 Gigabit Ethernet PHY (RGMII) > + * - SYN43752 WiFi 6 + BT 5.x (SDIO + UART4) > + * > + * Copyright (c) 2024 ArmSoM > + * Copyright (c) 2026 Jiaxing Hu <huhuvmb88@gmail.com> > + */ > + > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/pinctrl/rockchip.h> > +#include "rk3576.dtsi" > + > +/ { > + compatible = "armsom,cm5", "rockchip,rk3576"; > + > + vcc_1v1_nldo_s3: regulator-vcc-1v1-nldo-s3 { > + compatible = "regulator-fixed"; > + regulator-name = "vcc_1v1_nldo_s3"; > + regulator-boot-on; > + regulator-always-on; > + regulator-min-microvolt = <1100000>; > + regulator-max-microvolt = <1100000>; > + vin-supply = <&vcc_5v0_sys>; > + }; > + > + vcc_1v2_ufs_vccq_s0: regulator-vcc-1v2-ufs-vccq-s0 { Unused, drop > + compatible = "regulator-fixed"; > + regulator-name = "vcc_1v2_ufs_vccq_s0"; > + regulator-boot-on; > + regulator-always-on; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + vin-supply = <&vcc_5v0_sys>; > + }; > + > + vcc_1v8_s0: regulator-vcc-1v8-s0 { Also unused, drop. Drop all unused uncontrollable stubs which are not used by devices. They are completely redundant and pointless. > + compatible = "regulator-fixed"; > + regulator-name = "vcc_1v8_s0"; > + regulator-boot-on; > + regulator-always-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vcc_1v8_s3>; > + }; > + > + vcc_1v8_ufs_vccq2_s0: regulator-vcc-1v8-ufs-vccq2-s0 { > + compatible = "regulator-fixed"; > + regulator-name = "vcc_1v8_ufs_vccq2_s0"; > + regulator-boot-on; > + regulator-always-on; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <&vcc_1v8_s3>; > + }; > + > + vcc_2v0_pldo_s3: regulator-vcc-2v0-pldo-s3 { > + compatible = "regulator-fixed"; > + regulator-name = "vcc_2v0_pldo_s3"; > + regulator-boot-on; > + regulator-always-on; > + regulator-min-microvolt = <2000000>; > + regulator-max-microvolt = <2000000>; > + vin-supply = <&vcc_5v0_sys>; > + }; > + > + vcc_3v3_s0: regulator-vcc-3v3-s0 { > + compatible = "regulator-fixed"; > + regulator-name = "vcc_3v3_s0"; > + regulator-boot-on; > + regulator-always-on; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + vin-supply = <&vcc_3v3_s3>; > + }; > + > + vcc_3v3_ufs_s0: regulator-vcc-ufs-s0 { > + compatible = "regulator-fixed"; > + regulator-name = "vcc_3v3_ufs_s0"; > + regulator-boot-on; > + regulator-always-on; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + vin-supply = <&vcc_5v0_sys>; > + }; > + > + /* > + * WiFi power sequencer for SYN43752. Reset GPIO1 PC6 active-low, > + * clock from the HYM8563 RTC oscillator. > + */ > + sdio_pwrseq: sdio-pwrseq { > + compatible = "mmc-pwrseq-simple"; > + clocks = <&hym8563>; > + clock-names = "ext_clock"; > + pinctrl-names = "default"; > + pinctrl-0 = <&wifi_poweren_gpio>; > + reset-gpios = <&gpio1 RK_PC6 GPIO_ACTIVE_LOW>; > + }; > +}; > + > +&cpu_b0 { > + cpu-supply = <&vdd_cpu_big_s0>; > +}; > + > +&cpu_b1 { > + cpu-supply = <&vdd_cpu_big_s0>; > +}; > + > +&cpu_b2 { > + cpu-supply = <&vdd_cpu_big_s0>; > +}; > + > +&cpu_b3 { > + cpu-supply = <&vdd_cpu_big_s0>; > +}; > + > +&cpu_l0 { > + cpu-supply = <&vdd_cpu_lit_s0>; > +}; > + > +&cpu_l1 { > + cpu-supply = <&vdd_cpu_lit_s0>; > +}; > + > +&cpu_l2 { > + cpu-supply = <&vdd_cpu_lit_s0>; > +}; > + > +&cpu_l3 { > + cpu-supply = <&vdd_cpu_lit_s0>; > +}; > + > +/* > + * GMAC0 + on-module MotorComm YT8531 in rgmii-rxid mode (MAC TX delay 0x21, > + * PHY does RX delay). The YT8531 has NO local crystal, so it relies on the > + * SoC 25 MHz reference: clk_mac_refout (= REFCLKO25M_GMAC0_OUT) must be listed > + * on the gmac node - dwmac-rk only enables/routes it when named here - and the > + * ethm0_clk0_25m_out pin routes it to the pad. PHY reset via the MAC > + * (snps,reset) so stmmac releases it before the MDIO scan. > + */ > +&gmac0 { > + phy-mode = "rgmii-rxid"; > + clock_in_out = "output"; > + clocks = <&cru CLK_GMAC0_125M_SRC>, <&cru CLK_GMAC0_RMII_CRU>, > + <&cru PCLK_GMAC0>, <&cru ACLK_GMAC0>, > + <&cru CLK_GMAC0_PTP_REF>, <&cru REFCLKO25M_GMAC0_OUT>; > + clock-names = "stmmaceth", "clk_mac_ref", "pclk_mac", "aclk_mac", > + "ptp_ref", "clk_mac_refout"; > + tx_delay = <0x21>; > + rx_delay = <0x00>; > + phy-handle = <&rgmii_phy0>; > + phy-supply = <&vcc_3v3_s3>; > + snps,reset-gpios = <&gpio2 RK_PB3 GPIO_ACTIVE_LOW>; > + snps,reset-delays-us = <0 20000 100000>; > + pinctrl-names = "default"; > + pinctrl-0 = <ð0m0_miim > + ð0m0_tx_bus2 > + ð0m0_rx_bus2 > + ð0m0_rgmii_clk > + ð0m0_rgmii_bus > + ðm0_clk0_25m_out>; > + status = "okay"; > +}; > + > +&gpu { > + mali-supply = <&vdd_gpu_s0>; > + status = "okay"; > +}; > + > +/* I2C1: RK806 PMIC @ 0x23 (interrupt on GPIO0 PA6). */ > +&i2c1 { > + status = "okay"; > + > + pmic@23 { > + compatible = "rockchip,rk806"; > + reg = <0x23>; > + > + interrupt-parent = <&gpio0>; > + interrupts = <RK_PA6 IRQ_TYPE_LEVEL_LOW>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>, > + <&rk806_dvs2_null>, <&rk806_dvs3_null>; > + > + system-power-controller; > + > + vcc1-supply = <&vcc_5v0_sys>; > + vcc2-supply = <&vcc_5v0_sys>; > + vcc3-supply = <&vcc_5v0_sys>; > + vcc4-supply = <&vcc_5v0_sys>; > + vcc5-supply = <&vcc_5v0_sys>; > + vcc6-supply = <&vcc_5v0_sys>; > + vcc7-supply = <&vcc_5v0_sys>; > + vcc8-supply = <&vcc_5v0_sys>; > + vcc9-supply = <&vcc_5v0_sys>; > + vcc10-supply = <&vcc_5v0_sys>; > + vcc11-supply = <&vcc_2v0_pldo_s3>; > + vcc12-supply = <&vcc_5v0_sys>; > + vcc13-supply = <&vcc_1v1_nldo_s3>; > + vcc14-supply = <&vcc_1v1_nldo_s3>; > + vcca-supply = <&vcc_5v0_sys>; If fusb302@22 was enabled (status=okay), then why isn't this one as well? What sort of logic drives this? > + > + gpio-controller; > + #gpio-cells = <2>; > + > + rk806_dvs1_null: dvs1-null-pins { > + pins = "gpio_pwrctrl1"; > + function = "pin_fun0"; > + }; Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-07-16 8:23 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-07-16 1:28 [PATCH 0/2] arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO Jiaxing Hu 2026-07-16 1:28 ` [PATCH 1/2] dt-bindings: arm: " Jiaxing Hu 2026-07-16 8:23 ` Krzysztof Kozlowski 2026-07-16 1:28 ` [PATCH 2/2] arm64: dts: " Jiaxing Hu 2026-07-16 1:40 ` sashiko-bot 2026-07-16 6:55 ` Jiaxing Hu 2026-07-16 8:23 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox