Re: [PATCH 1/2] dt-bindings: arm: rockchip: Add Vicharak Vaaman board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly introduced vendor prefix 'vicharak' is used in a new compatible string but is not documented in vendor-prefixes.yaml.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: arm: rockchip: Add Vicharak Vaaman board ---
commit 64f97a8b2f6425cd87099ddd140688e38540d5e4
Author: Hrushiraj Gandhi <hrushirajg23@gmail.com>

dt-bindings: arm: rockchip: Add Vicharak Vaaman board
    
This commit documents the compatible string for the Vicharak Vaaman, an 
RK3399-based single-board computer.

> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 1a9dde18626d0..7cfd3687768cf 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml

[ ... ]

> @@ -1306,6 +1306,11 @@ properties:
>            - const: turing,rk1
>            - const: rockchip,rk3588
>  
> +      - description: Vicharak Vaaman
> +        items:
> +          - const: vicharak,vaaman

[Severity: Low]
Does the new vendor prefix vicharak need to be added to 
Documentation/devicetree/bindings/vendor-prefixes.yaml alongside a 
description of the vendor?

Using an undocumented vendor prefix will cause make dt_binding_check and 
checkpatch.pl to generate warnings or fail due to schema validation errors.

> +          - const: rockchip,rk3399
> +
>        - description: WolfVision PF5 mainboard
>          items:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716092859.512306-1-hrushirajg23@gmail.com?part=1