Re: [PATCH 2/2] arm64: dts: rockchip: Add Vicharak Vaaman board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Non-standard node name for the 12V fixed regulator.
--

--- Patch [2]: [PATCH 2/2] arm64: dts: rockchip: Add Vicharak Vaaman board ---
commit 5905db945adc2fafb8754e0bf1a749e342f70335
Author: Hrushiraj Gandhi <hrushirajg23@gmail.com>

arm64: dts: rockchip: Add Vicharak Vaaman board

Add initial devicetree support for the Vicharak Vaaman, an RK3399-based
single-board computer.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-vicharak-vaaman.dts b/arch/arm64/boot/dts/rockchip/rk3399-vicharak-vaaman.dts
> new file mode 100644
> index 0000000000000..6060365bf731b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-vicharak-vaaman.dts

[ ... ]

> +	clkin_gmac: external-gmac-clock {
> +		compatible = "fixed-clock";
> +		clock-frequency = <125000000>;
> +		clock-output-names = "clkin_gmac";
> +		#clock-cells = <0>;
> +	};
> +
> +	vcc12v_dcin: vcc12v-dcin-regulator {

[Severity: Low]
This isn't a bug, but does the node name "vcc12v-dcin-regulator" violate the
preferred naming pattern for fixed regulators?

According to the fixed-regulator bindings, node names should ideally match
the regex ^regulator(-[0-9]+v[0-9]+|-[0-9a-z-]+)?$. Should this be renamed
to something like "regulator-12v-dcin"?

> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc12v_dcin";
> +		regulator-always-on;
> +		regulator-boot-on;
> +		regulator-min-microvolt = <12000000>;
> +		regulator-max-microvolt = <12000000>;
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716092859.512306-1-hrushirajg23@gmail.com?part=2