Re: [PATCH v3 2/2] arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The DisplayPort controller (`dp`) is not enabled and not routed to the VOP2, breaking the advertised Type-C DP alt-mode.
- [Medium] The `sai6` CPU DAI node is not enabled, which prevents the HDMI sound card from probing.
--

--- Patch [2]: [PATCH v3 2/2] arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO ---
commit 6aa295a8cc84993de39b6dae02d2c7333d9385bb
Author: Jiaxing Hu <gahing@gahingwoo.com>

arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO
    
This commit adds device tree files for the ArmSoM CM5, an RK3576 compute
module, and its CM5-IO carrier board. It configures peripherals such as
the RK806 PMIC, GMAC0, eMMC, HDMI, USB, and an M.2 PCIe slot.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts
[ ... ]
> @@ -174,6 +174,10 @@ hdmi_out_con: endpoint {
>  	};
>  };
>  
> +&hdmi_sound {
> +	status = "okay";
> +};

[Severity: Medium]
Will the HDMI sound card fail to probe without the sai6 CPU DAI enabled?

Since hdmi_sound relies on sai6 as its CPU endpoint (defined in the base
SoC dtsi), leaving &sai6 disabled in this board file might prevent ALSA
from registering the sound card, resulting in broken HDMI audio.

> +
>  &hdptxphy {
>  	status = "okay";
>  };
[ ... ]
> @@ -317,6 +321,21 @@ &usb_drd1_dwc3 {
>  	status = "okay";
>  };
>  
> +&usbdp_phy {
> +	status = "okay";
> +	mode-switch;
> +	orientation-switch;
> +	sbu1-dc-gpios = <&gpio4 RK_PC4 GPIO_ACTIVE_HIGH>;
> +	sbu2-dc-gpios = <&gpio4 RK_PC5 GPIO_ACTIVE_HIGH>;

[Severity: Medium]
Does the DisplayPort controller also need to be enabled for DP alt-mode to
function properly?

The usbdp_phy is configured for mode switching here, but the corresponding
&dp node and its VOP2 display pipeline endpoint appear to be missing or
disabled. Without the controller generating video data, will the Type-C
port fail to output a video signal?

> +
> +	port {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716095101.2498464-1-gahing@gahingwoo.com?part=2