Re: [PATCH v3 2/2] arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Silently ignored clock configuration on MDIO PHY node.
--

--- Patch [2]: [PATCH v3 2/2] arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO ---
commit 235c0c71486f5323f7d8535da556a6e07eb3e094
Author: Jiaxing Hu <gahing@gahingwoo.com>
Subject: arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO

This patch adds the ArmSoM CM5 compute module and its CM5-IO carrier board,
configuring peripherals such as GMAC0 with an on-module Ethernet PHY, USB,
PCIe, and HDMI. It also describes the reset and 25 MHz reference clock
required for the YT8531 Ethernet PHY.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5.dtsi b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5.dtsi
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5.dtsi
[ ... ]
> +&mdio0 {
> +	reset-gpios = <&gpio2 RK_PB3 GPIO_ACTIVE_LOW>;
> +	reset-delay-us = <20000>;
> +	reset-post-delay-us = <100000>;
> +
> +	rgmii_phy0: phy@1 {
> +		compatible = "ethernet-phy-ieee802.3-c22";
> +		reg = <0x1>;
> +		clocks = <&cru REFCLKO25M_GMAC0_OUT>;
> +		assigned-clocks = <&cru REFCLKO25M_GMAC0_OUT>;
> +		assigned-clock-rates = <25000000>;

[Severity: Medium]
Will these assigned clock properties be processed by the kernel?

Since this PHY is placed on the mdio bus, which doesn't process assigned-clocks
automatically like the platform bus does, it appears this configuration will be
silently ignored.

If the bootloader leaves this clock unconfigured, the Ethernet PHY might fail to
operate. Should these properties be moved to the parent platform device (gmac0)
instead, so that the 25 MHz reference clock rate takes effect?

> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716081711.2482259-1-gahing@gahingwoo.com?part=2