Re: [PATCH v3 2/4] arm64: dts: qcom: Enable Primary USB controller on Shikra CQS platform

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing `dr_mode = "peripheral"` prevents the USB controller from defaulting to device mode as intended.
--

--- Patch [2]: [PATCH v3 2/4] arm64: dts: qcom: Enable Primary USB controller on Shikra CQS platform ---
commit 2bd6f1e7b8937d47916fb8392363e93f8f9b7c35
Author: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>

arm64: dts: qcom: Enable Primary USB controller on Shikra CQS platform

This commit enables the primary USB controller and its associated PHYs on
the Shikra CQS platform, with the stated intent of configuring it in
device mode.

> diff --git a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
> index b3f19a64d7aed..2e96dadd650a7 100644
> --- a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
[ ... ]
> @@ -38,3 +38,22 @@ &sdhc_1 {
>  
>  	status = "okay";
>  };
> +
> +&usb_1 {
> +	status = "okay";
> +};

[Severity: Medium]
The commit message indicates the intent is to enable the primary USB
controller in device mode, but there is no dr_mode property specified here.

Does this missing property cause the dwc3 driver to default to OTG mode
during boot?

If there is no dynamic role switch defined to drive the role (like a Type-C
connector or extcon), will the controller just wait for a role switch event
and fail to function as a peripheral out of the box?

Should a dr_mode property be explicitly added to this node to ensure
it matches the behavior described in the commit message?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716-shikra-usb-dt-v3-v3-0-13f73a0571bb@oss.qualcomm.com?part=2