[PATCH] dt-bindings: usb: ti,da830-ohci: Convert to DT schema

[PATCH] dt-bindings: usb: ti,da830-ohci: Convert to DT schema

[Bhargav Joshi]

Convert Texas Instruments da830-ohci bindings from legacy text to DT
schema. Name of binding is changed to match primary compatible property.

Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
 .../devicetree/bindings/usb/ohci-da8xx.txt         | 23 ----------
 .../devicetree/bindings/usb/ti,da830-ohci.yaml     | 50 ++++++++++++++++++++++
 2 files changed, 50 insertions(+), 23 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/ohci-da8xx.txt b/Documentation/devicetree/bindings/usb/ohci-da8xx.txt
deleted file mode 100644
index 24a826d5015e..000000000000
--- a/Documentation/devicetree/bindings/usb/ohci-da8xx.txt
+++ /dev/null
@@ -1,23 +0,0 @@
-DA8XX USB OHCI controller
-
-Required properties:
-
- - compatible: Should be "ti,da830-ohci"
- - reg:        Should contain one register range i.e. start and length
- - interrupts: Description of the interrupt line
- - phys:       Phandle for the PHY device
- - phy-names:  Should be "usb-phy"
-
-Optional properties:
- - vbus-supply: phandle of regulator that controls vbus power / over-current
-
-Example:
-
-ohci: usb@225000 {
-        compatible = "ti,da830-ohci";
-        reg = <0x225000 0x1000>;
-        interrupts = <59>;
-        phys = <&usb_phy 1>;
-        phy-names = "usb-phy";
-        vbus-supply = <&reg_usb_ohci>;
-};
diff --git a/Documentation/devicetree/bindings/usb/ti,da830-ohci.yaml b/Documentation/devicetree/bindings/usb/ti,da830-ohci.yaml
new file mode 100644
index 000000000000..ad23da646648
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/ti,da830-ohci.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/ti,da830-ohci.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: DA8XX USB OHCI controller
+
+maintainers:
+  - Axel Haslam <ahaslam@baylibre.com>
+
+properties:
+  compatible:
+    const: ti,da830-ohci
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  phys:
+    maxItems: 1
+
+  phy-names:
+    const: usb-phy
+
+  vbus-supply:
+    description:
+      phandle of regulator that controls vbus power / over-current
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - phys
+  - phy-names
+
+additionalProperties: false
+
+examples:
+  - |
+    usb@225000 {
+        compatible = "ti,da830-ohci";
+        reg = <0x225000 0x1000>;
+        interrupts = <59>;
+        phys = <&usb_phy 1>;
+        phy-names = "usb-phy";
+        vbus-supply = <&reg_usb_ohci>;
+    };

---
base-commit: ef0c9f75a19532d7675384708fc8621e10850104
change-id: 20260622-ti-da830-ohci-2a2299d045e2

Best regards,
--  
Bhargav

Re: [PATCH] dt-bindings: usb: ti,da830-ohci: Convert to DT schema

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The converted YAML schema omits the `clocks` and `oc-gpios` properties. Since `additionalProperties: false` is set, `make dtbs_check` will incorrectly fail for existing valid device trees that use these properties. Furthermore, `clocks` is a mandatory hardware requirement, as the driver's probe function will fail without it.
--

--- Patch [1]: [PATCH] dt-bindings: usb: ti,da830-ohci: Convert to DT schema ---
commit 7116233f47fab25581fee6b5a4f1df2b63c1d5a9
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

dt-bindings: usb: ti,da830-ohci: Convert to DT schema

Convert Texas Instruments da830-ohci bindings from legacy text to DT
schema. Name of binding is changed to match primary compatible property.

> diff --git a/Documentation/devicetree/bindings/usb/ti,da830-ohci.yaml b/Documentation/devicetree/bindings/usb/ti,da830-ohci.yaml
> new file mode 100644
> index 0000000000000..ad23da6466487
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ti,da830-ohci.yaml
> @@ -0,0 +1,50 @@

[ ... ]

> +  vbus-supply:
> +    description:
> +      phandle of regulator that controls vbus power / over-current
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - phys
> +  - phy-names
> +
> +additionalProperties: false

[Severity: Medium]
Because this schema enforces additionalProperties: false, won't make
dtbs_check incorrectly report validation errors for existing device trees
that include clocks or oc-gpios?

Existing device trees like arch/arm/boot/dts/ti/davinci/da850.dtsi define
a clocks property for this device:

arch/arm/boot/dts/ti/davinci/da850.dtsi:usb1() {
        ...
        phy-names = "usb-phy";
        clocks = <&psc1 2>;
        ...
}

Additionally, the driver drivers/usb/host/ohci-da8xx.c checks for an optional
"oc" GPIO (which translates to oc-gpios in the device tree):

drivers/usb/host/ohci-da8xx.c:ohci_da8xx_probe() {
        ...
        da8xx_ohci->oc_gpio = devm_gpiod_get_optional(dev, "oc", GPIOD_IN);
        ...
}

Furthermore, should clocks be added to the required list? The driver's probe
function appears to fail if the clock is missing:

drivers/usb/host/ohci-da8xx.c:ohci_da8xx_probe() {
        ...
        da8xx_ohci->usb11_clk = devm_clk_get(dev, NULL);
        if (IS_ERR(da8xx_ohci->usb11_clk)) {
        ...
}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717-ti-da830-ohci-v1-1-3f2d111a2042@gmail.com?part=1