From: sashiko-bot@kernel.org
To: "Jerome Brunet" <jbrunet@baylibre.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 3/4] mfd: axp20x: constify axp313 and axp717 cells
Date: Fri, 17 Jul 2026 09:08:19 +0000 [thread overview]
Message-ID: <20260717090819.BFC501F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260717-axp318-regulator-v3-3-779dc1b97dd4@baylibre.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message description is not capitalized, violating the MFD subsystem convention.
--
--- Patch [3]: [PATCH v3 3/4] mfd: axp20x: constify axp313 and axp717 cells ---
commit fa2a5821d61bb79ab715c28d8480fa7cf50eb9a0
Author: Jerome Brunet <jbrunet@baylibre.com>
mfd: axp20x: constify axp313 and axp717 cells
This commit constifies the mfd_cells arrays for the axp313 and axp717 chips
to match other supported devices.
> mfd: axp20x: constify axp313 and axp717 cells
[Severity: Low]
This isn't a bug, but the MFD subsystem guidelines request that the
description following the subsystem prefix be capitalized. Should this be
updated to "Constify axp313 and axp717 cells" to match the standard subsystem
naming conventions?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260717-axp318-regulator-v3-0-779dc1b97dd4@baylibre.com?part=3
next prev parent reply other threads:[~2026-07-17 9:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 8:44 [PATCH v3 0/4] regulator: Add X-Powers AXP318W PMIC support Jerome Brunet
2026-07-17 8:44 ` [PATCH v3 1/4] dt-bindings: mfd: x-powers,axp152: Document AXP318W Jerome Brunet
2026-07-17 8:44 ` [PATCH v3 2/4] mfd: axp20x: Add support for AXP318W PMIC Jerome Brunet
2026-07-17 9:02 ` sashiko-bot
2026-07-17 9:51 ` Jerome Brunet
2026-07-17 8:44 ` [PATCH v3 3/4] mfd: axp20x: constify axp313 and axp717 cells Jerome Brunet
2026-07-17 9:08 ` sashiko-bot [this message]
2026-07-17 8:44 ` [PATCH v3 4/4] regulator: axp20x: add support for the AXP318W Jerome Brunet
2026-07-17 9:18 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717090819.BFC501F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox