Re: [PATCH v3 4/4] regulator: axp20x: add support for the AXP318W

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Unhandled AXP318_ID variant in `axp20x_set_dcdc_workmode` triggers a kernel splat if `x-powers,dcdc-workmode` is in the Device Tree.
--

--- Patch [4]: [PATCH v3 4/4] regulator: axp20x: add support for the AXP318W ---
commit 8de3219334d650160512cfdeb429dbaddb9ab5cb
Author: Andre Przywara <andre.przywara@arm.com>

regulator: axp20x: add support for the AXP318W

The X-Powers AXP318W is a typical PMIC from X-Powers, featuring nine
DC/DC converters and 28 LDOs, on the regulator side. Describe the chip's
voltage settings and switch registers, how the voltages are encoded, and
connect this to the MFD device via its regulator ID.

> diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
> index da891415efc0b..6f887250d6402 100644
> --- a/drivers/regulator/axp20x-regulator.c
> +++ b/drivers/regulator/axp20x-regulator.c

[ ... ]

> @@ -1585,6 +1858,10 @@ static int axp20x_regulator_probe(struct platform_device *pdev)
>  		regulators = axp313a_regulators;
>  		nregulators = AXP313A_REG_ID_MAX;
>  		break;
> +	case AXP318_ID:
> +		regulators = axp318_regulators;
> +		nregulators = AXP318_REG_ID_MAX;
> +		break;
>  	case AXP717_ID:
>  		regulators = axp717_regulators;
>  		nregulators = AXP717_REG_ID_MAX;

[Severity: Medium]
Could this trigger a kernel splat if the device tree contains the
"x-powers,dcdc-workmode" property for an AXP318 regulator?

During initialization in axp20x_regulator_probe(), the property is read
and passed to axp20x_set_dcdc_workmode():

	ret = of_property_read_u32(rdev->dev.of_node,
				   "x-powers,dcdc-workmode",
				   &workmode);
	if (!ret) {
		if (axp20x_set_dcdc_workmode(rdev, i, workmode))
...

However, axp20x_set_dcdc_workmode() does not seem to handle AXP318_ID
in its switch statement, which will cause it to fall through to the
default case:

	default:
		/* should not happen */
		WARN_ON(1);
		return -EINVAL;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717-axp318-regulator-v3-0-779dc1b97dd4@baylibre.com?part=4