From: sashiko-bot@kernel.org
To: "Jerome Brunet" <jbrunet@baylibre.com>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
linux-sunxi@lists.linux.dev, conor+dt@kernel.org,
devicetree@vger.kernel.org, robh@kernel.org,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH v5 3/4] clk: sunxi-ng: sun6i-rtc: split main oscillator div and gate.
Date: Fri, 17 Jul 2026 15:33:18 +0000 [thread overview]
Message-ID: <20260717153319.5B7921F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260717-a733-rtc-v5-3-3874cc26abf7@baylibre.com>
> On the a733 the "osc24M-32k" clock has the same gate bits as the previously
> supported SoC but a different divider implementation.
>
> Instead of a fixed 750 divider, the divider is selected based on the
> rate of the oscillator. It can be seen as a simple read-only divider.
>
> On the A733 the gate and the divider are on different register which is
> not supported by sunxi combined clocks. These element will be split on the
> A733. Split them for the older SoC as well to keep on sharing the gate
> definition.
>
> Reviewed-by: Chen-Yu Tsai <wens@kernel.org>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260717-a733-rtc-v5-0-3874cc26abf7@baylibre.com?part=3
next prev parent reply other threads:[~2026-07-17 15:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 15:24 [PATCH v5 0/4] clk: sun6i-rtc: Add support for Allwinner A733 SoC Jerome Brunet
2026-07-17 15:24 ` [PATCH v5 1/4] clk: sunxi-ng: mux: fix determine helper rate propagation Jerome Brunet
2026-07-17 15:49 ` sashiko-bot
2026-07-17 15:24 ` [PATCH v5 2/4] clk: sunxi-ng: div: add read-only operation support Jerome Brunet
2026-07-17 15:40 ` sashiko-bot
2026-07-17 15:24 ` [PATCH v5 3/4] clk: sunxi-ng: sun6i-rtc: split main oscillator div and gate Jerome Brunet
2026-07-17 15:33 ` sashiko-bot [this message]
2026-07-17 15:24 ` [PATCH v5 4/4] clk: sunxi-ng: sun6i-rtc: add a733 support Jerome Brunet
2026-07-17 15:40 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717153319.5B7921F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox