Re: [PATCH 2/2] soc/tegra: pmc: Add Tegra210B01 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unnecessary code duplication of identical pad and pin description arrays for Tegra210B01.
--

--- Patch [2]: [PATCH 2/2] soc/tegra: pmc: Add Tegra210B01 support ---
commit 79bca764e8d02b78b29f77c96575489573ae132e
Author: Azkali Manad <a.ffcc7@gmail.com>

soc/tegra: pmc: Add Tegra210B01 support

This commit adds support for the Tegra210B01 SoC to the Tegra PMC driver.
It introduces new powergates, IO pads, voltage controls, and pin descriptions
specifically for this variant.

> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index f419a5395545f..4d77aa66d690c 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
[ ... ]
> @@ -3897,6 +3923,139 @@ static const struct tegra_pmc_soc tegra210_pmc_soc = {
>  	.has_single_mmio_aperture = true,
>  };
>  
> +static const struct tegra_io_pad_soc tegra210b01_io_pads[] = {

[Severity: Low]
Are these IO pad arrays identical to the existing tegra210 versions?

Looking at tegra210_io_pads, tegra210_io_pad_vctrls, and tegra210_pin_descs,
it seems this code duplicates them exactly. Could tegra210b01_pmc_soc directly
reference the existing tegra210 arrays instead of duplicating these structures
to reduce binary size?

> +	TEGRA_IO_PAD(TEGRA_IO_PAD_AUDIO, 17, 0x1b8, 0x1bc, "audio"),
> +	TEGRA_IO_PAD(TEGRA_IO_PAD_AUDIO_HV, 29, 0x1c0, 0x1c4, "audio-hv"),
[ ... ]
> +	TEGRA_IO_PAD(TEGRA_IO_PAD_USB_BIAS, 12, 0x1b8, 0x1bc, "usb-bias"),
> +};
> +
> +static const struct tegra_io_pad_vctrl tegra210b01_io_pad_vctrls[] = {
> +	TEGRA_IO_PAD_VCTRL(TEGRA_IO_PAD_AUDIO, PMC_PWR_DET_VALUE, 5),
[ ... ]
> +	TEGRA_IO_PAD_VCTRL(TEGRA_IO_PAD_UART, PMC_PWR_DET_VALUE, 2),
> +};
> +
> +static const struct pinctrl_pin_desc tegra210b01_pin_descs[] = {
> +	TEGRA_IO_PIN_DESC(TEGRA_IO_PAD_AUDIO, "audio"),
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717-t210b01-pmc-v1-0-bf776be8b3a7@gmail.com?part=2