Devicetree
 help / color / mirror / Atom feed
From: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
To: "Paweł Wiśniewski" <pawel.wis.me@gmail.com>
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	ak@it-klinger.de, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/3] dt-bindings: iio: proximity: Add Cytron HC-SR04
Date: Sat, 18 Jul 2026 23:45:19 +0100	[thread overview]
Message-ID: <20260718234506.6aecbc9b@jic23-huawei> (raw)
In-Reply-To: <bb79ea1b842e062dd47bd1fb31fdd15a9ef76c29.1784221074.git.pawel.wis.me@gmail.com>

On Thu, 16 Jul 2026 19:35:55 +0200
Paweł Wiśniewski <pawel.wis.me@gmail.com> wrote:

> The Cytron HC-SR04 starts a ranging cycle with an active-high trigger
> pulse of at least 10 us and reports the acoustic round-trip time as
> the width of an active-high echo pulse.
> 
> Add the cytron,hc-sr04 compatible and a reference to the product
> manual. Update the trigger GPIO description to account for the pulse
> durations used by the supported devices.
> 
> The interface matches the two-GPIO protocol implemented by the
> existing SRF04 driver.

Is it suited to using a fallback compatible to one of those already
supported parts?  This should say where things are different.

> 
> Assisted-by: ChatGPT:GPT-5.6 Thinking
> Signed-off-by: Paweł Wiśniewski <pawel.wis.me@gmail.com>
> ---
>  .../devicetree/bindings/iio/proximity/devantech-srf04.yaml   | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml b/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml
> index ce795279839e..f4237ae612ab 100644
> --- a/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml
> +++ b/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml
> @@ -4,7 +4,7 @@
>  $id: http://devicetree.org/schemas/iio/proximity/devantech-srf04.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Devantech SRF04 and Maxbotix mb1000 ultrasonic range finder
> +title: Devantech SRF04 and Maxbotix mb1000 and Cytron HC-SR04 ultrasonic range finder
If we were going to keep the list going it would need to be:
title: Devantech SRF04, Maxbotix mb1000 and Cytron HC-SR04 ultrasonic range finder

However, previous experience suggests that sooner or later it is better to just
jump to Devantech SRF04 and similar.

>  
>  maintainers:
>    - Andreas Klinger <ak@it-klinger.de>
> @@ -21,9 +21,12 @@ description: |
>  
>    https://www.maxbotix.com/documents/LV-MaxSonar-EZ_Datasheet.pdf
>  
> +  https://botland.com.pl/index.php?controller=attachment&id_attachment=476
> +
>  properties:
>    compatible:
>      enum:
> +      - cytron,hc-sr04
>        - devantech,srf04
>        - maxbotix,mb1000
>        - maxbotix,mb1010


  parent reply	other threads:[~2026-07-18 22:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16 17:35 [RFC PATCH 0/3] iio: proximity: Add Cytron HC-SR04 support Paweł Wiśniewski
2026-07-16 17:35 ` [RFC PATCH 1/3] dt-bindings: vendor-prefixes: Add Cytron Technologies Paweł Wiśniewski
2026-07-16 17:35 ` [RFC PATCH 2/3] dt-bindings: iio: proximity: Add Cytron HC-SR04 Paweł Wiśniewski
2026-07-16 17:45   ` sashiko-bot
2026-07-18 22:45   ` Jonathan Cameron [this message]
2026-07-16 17:35 ` [RFC PATCH 3/3] iio: proximity: srf04: Add Cytron HC-SR04 support Paweł Wiśniewski
2026-07-16 17:46   ` sashiko-bot
2026-07-18 22:47   ` Jonathan Cameron
2026-07-16 18:22 ` [RFC PATCH 0/3] iio: proximity: " Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260718234506.6aecbc9b@jic23-huawei \
    --to=jonathan.cameron@oss.qualcomm.com \
    --cc=ak@it-klinger.de \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=pawel.wis.me@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox