Devicetree
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: display: panel-lvds: Add boe,dv215fhm-r01 compatible
@ 2026-07-19 16:08 Vishnu Saini
  2026-07-19 16:15 ` sashiko-bot
  0 siblings, 1 reply; 2+ messages in thread
From: Vishnu Saini @ 2026-07-19 16:08 UTC (permalink / raw)
  To: Laurent Pinchart, Neil Armstrong, Jessica Zhang,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
	Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Lad Prabhakar, Thierry Reding
  Cc: dri-devel, devicetree, linux-kernel, venkata.valluru,
	Jessica Zhang, Vishnu Saini

Add BOE DV215FHM-R01 21.5" FHD (1920x1080) dual-channel LVDS panel
compatible string to the panel-lvds binding.

Also remove the 'port' requirement from the required list to allow
dual-channel LVDS panels to use the 'ports' graph topology with
separate port@0 (odd pixels) and port@1 (even pixels) nodes, as
required by the dual-LVDS binding.

Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
---
 .../devicetree/bindings/display/panel/panel-lvds.yaml          | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
index b89f86bc0683..584818b2df6e 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
@@ -58,6 +58,8 @@ properties:
           - hydis,hv070wx2-1e0
           # Jenson Display BL-JT60050-01A 7" WSVGA (1024x600) color TFT LCD LVDS panel
           - jenson,bl-jt60050-01a
+          # BOE DV215FHM-R01 21.5" FHD (1920x1080) dual-channel LVDS panel
+          - boe,dv215fhm-r01
           # Riverdi RVT101HVLNWC00 10.1" WXGA (1280x800) TFT LCD LVDS panel
           - riverdi,rvt101hvlnwc00
           # Riverdi RVT70HSLNWCA0 7.0" WSVGA (1024x600) TFT LCD LVDS panel
@@ -72,6 +74,12 @@ properties:
 
       - const: panel-lvds
 
+  ports:
+    $ref: /schemas/graph.yaml#/properties/ports
+    description:
+      For dual-channel LVDS panels, use 'ports' with port@0 for odd pixels
+      and port@1 for even pixels instead of the single 'port' property.
+
 unevaluatedProperties: false
 
 required:
@@ -80,6 +88,4 @@ required:
   - width-mm
   - height-mm
   - panel-timing
-  - port
-
 ...

---
base-commit: 104c00917264c5b9571072471e3a8689cd1a2c4d
change-id: 20260719-b4-lvds-panel-doc-cb503c4ba2be

Best regards,
-- 
Vishnu Saini <vishnu.saini@oss.qualcomm.com>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: display: panel-lvds: Add boe,dv215fhm-r01 compatible
  2026-07-19 16:08 [PATCH] dt-bindings: display: panel-lvds: Add boe,dv215fhm-r01 compatible Vishnu Saini
@ 2026-07-19 16:15 ` sashiko-bot
  0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-07-19 16:15 UTC (permalink / raw)
  To: Vishnu Saini; +Cc: robh, dri-devel, conor+dt, devicetree

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Removing 'port' from the global required list without conditional replacements allows all panels to omit their display controller connection.
- [Medium] The schema fails to apply the dual-LVDS binding for the new dual-channel panel, breaking validation for pixel-order properties.
--

--- Patch [1]: [PATCH] dt-bindings: display: panel-lvds: Add boe,dv215fhm-r01 compatible ---
commit dda569bad0ff68efade6e9633f374c324001833a
Author: Vishnu Saini <vishnu.saini@oss.qualcomm.com>

dt-bindings: display: panel-lvds: Add boe,dv215fhm-r01 compatible

This commit adds the BOE DV215FHM-R01 21.5" dual-channel LVDS panel
to the panel-lvds binding. It also removes the global port requirement
to allow dual-channel panels to use the ports topology with separate
port@0 and port@1 nodes.

> diff --git a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
> index b89f86bc06837..584818b2df6ea 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml

[ ... ]

> @@ -72,6 +74,12 @@ properties:
>  
>        - const: panel-lvds
>  
> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
> +    description:
> +      For dual-channel LVDS panels, use 'ports' with port@0 for odd pixels
> +      and port@1 for even pixels instead of the single 'port' property.

[Severity: Medium]
Since the boe,dv215fhm-r01 compatible requires dual-LVDS properties like
dual-lvds-odd-pixels and dual-lvds-even-pixels in its ports, shouldn't this
schema conditionally reference /schemas/display/lvds-dual-ports.yaml?

Without referencing the dual-LVDS schema, won't these properties fail
validation as unrecognized properties, or fail to have their mandatory
presence enforced when someone instantiates this dual-channel panel?

> +
>  unevaluatedProperties: false
>  
>  required:
> @@ -80,6 +88,4 @@ required:
>    - width-mm
>    - height-mm
>    - panel-timing
> -  - port
> -
>  ...

[Severity: High]
Does removing port from the global required list without providing
conditional replacements allow all existing single-channel LVDS panels to
silently pass validation even if they omit their display controller
connection?

Would it be safer to enforce this requirement using an anyOf block such as
anyOf: [{required: [port]}, {required: [ports]}], or to use conditional
if-then blocks to ensure validation constraints for prior generations are
not globally relaxed?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260719-b4-lvds-panel-doc-v1-1-6a18c213c2f6@oss.qualcomm.com?part=1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-07-19 16:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-19 16:08 [PATCH] dt-bindings: display: panel-lvds: Add boe,dv215fhm-r01 compatible Vishnu Saini
2026-07-19 16:15 ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox