From: sashiko-bot@kernel.org
To: "Vic B" <linux@vicb.net>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: fix label of sys_led for nanopi-r4s
Date: Sun, 19 Jul 2026 16:19:13 +0000 [thread overview]
Message-ID: <20260719161914.77CA01F000E9@smtp.kernel.org> (raw)
In-Reply-To: <alz112qGhm77liqi@vicb.net>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch assigns a new value to the deprecated `label` property instead of modernizing the LED Device Tree binding to use `color` and `function`.
--
--- Patch [1]: [PATCH] arm64: dts: rockchip: fix label of sys_led for nanopi-r4s ---
commit ceee1e0876cda2fa407388b630cd3de2ef149410
Author: Vic B <linux@vicb.net>
arm64: dts: rockchip: fix label of sys_led for nanopi-r4s
This commit corrects the system LED configuration for the NanoPi R4S by
changing the label from red:power to green:sys. It aligns the device tree
with the physical board schematics.
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dtsi
> index 4274d1b6e80ae..6fbc76e2e679e 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi-r4s.dtsi
> @@ -31,7 +31,7 @@ lan_led: led-lan {
>
> sys_led: led-sys {
> gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_HIGH>;
> - label = "red:power";
> + label = "green:sys";
[Severity: Low]
Since the label property is deprecated in modern LED Device Tree bindings,
would it be better to replace this with the color and function properties?
Modern user-space LED managers rely on standard sysfs directories named
color:function. Defining the LED using the color and function properties
would align the driver with current subsystem guidelines and prevent
userspace from relying on the legacy label field to correctly identify
the hardware role.
> default-state = "on";
> };
>
--
Sashiko AI review · https://sashiko.dev/#/patchset/alz112qGhm77liqi@vicb.net?part=1
next prev parent reply other threads:[~2026-07-19 16:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 16:05 [PATCH] arm64: dts: rockchip: fix label of sys_led for nanopi-r4s Vic B
2026-07-19 16:19 ` sashiko-bot [this message]
2026-07-19 18:49 ` [PATCH v2] " Vic B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260719161914.77CA01F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux@vicb.net \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox