Re: [PATCH v3] dt-bindings: pinctrl: microchip,pic32mzda-pinctrl: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The regular expressions used for matching pin configuration nodes contain invalid syntax (negative lookaheads unsupported by the RE2 engine) and overly restrictive patterns that reject standard Device Tree node naming conventions.
--

--- Patch [1]: [PATCH v3] dt-bindings: pinctrl: microchip,pic32mzda-pinctrl: Convert to DT schema ---
commit e4c63aad2379e3c473b66cca58b14faae98c368f
Author: Udaya Kiran Challa <challauday369@gmail.com>

dt-bindings: pinctrl: microchip,pic32mzda-pinctrl: Convert to DT schema

Convert Microchip PIC32 Pin Controller devicetree binding
from legacy text format to DT schema.

> diff --git a/Documentation/devicetree/bindings/pinctrl/microchip,pic32mzda-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/microchip,pic32mzda-pinctrl.yaml
> new file mode 100644
> index 0000000000000..7a36e5ff61ddf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/microchip,pic32mzda-pinctrl.yaml
> @@ -0,0 +1,153 @@

[ ... ]

> +  '#size-cells':
> +    const: 1
> +
> +patternProperties:
> +  '^(?!pinctrl_)[a-z]+[0-9]*_[a-z0-9_]+$':

[Severity: Medium]
Will this negative lookahead cause a schema compilation error during
make dt_binding_check?

The dt-schema tool requires RE2-compatible regexes, which do not support
negative lookaheads. Additionally, strictly requiring an underscore in the
node name violates standard Device Tree node naming conventions.

> +    type: object
> +    $ref: pinmux-node.yaml#

[ ... ]

> +    unevaluatedProperties: false
> +
> +  '^pinctrl_[a-z0-9_-]+$|^[a-z]+[0-9]+-[0-9]+$':

[Severity: Medium]
Is this pattern too restrictive for container nodes?

By requiring a pinctrl_ prefix or strictly ending in a number, this pattern
rejects valid generic node names like uart-pins, which could break schema
validation for conformant device trees.

> +    type: object
> +    description: |
> +      Container node for grouped pin configuration sub-nodes.
> +
> +    patternProperties:
> +      '^[a-z]+[0-9]+-[a-z]+$':

[Severity: Medium]
Does this child sub-node pattern improperly reject standard single-instance
interfaces?

The regex requires a number before a hyphen, which means valid generic names
like spi-mosi will fail to match.

> +        type: object
> +        $ref: pinmux-node.yaml#

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260719183431.124061-1-challauday369@gmail.com?part=1