Re: [PATCH v3 1/4] dt-bindings: hwmon: (pmbus/max20830): add VOUT feedback resistor properties and complete examples

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing `#include <dt-bindings/gpio/gpio.h>` in the examples section causes `make dt_binding_check` to fail.
--

--- Patch [1]: [PATCH v3 1/4] dt-bindings: hwmon: (pmbus/max20830): add VOUT feedback resistor properties and complete examples ---
commit f18524325452b02a7accd64c49a8b82f9362d94c
Author: Alexis Czezar Torreno <alexisczezar.torreno@analog.com>

dt-bindings: hwmon: (pmbus/max20830): add VOUT feedback resistor properties and complete examples

This commit adds properties for external voltage divider configuration for
VOUT sensing (adi,vout-rfb1-ohms and adi,vout-rfb2-ohms) to the MAX20830
binding. It also adds missing entries to the example device tree node.

> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20830.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20830.yaml
> --- a/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20830.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,max20830.yaml

[ ... ]

> @@ -61,6 +76,11 @@ examples:
>              compatible = "adi,max20830";
>              reg = <0x30>;
>              vddh-supply = <&vddh>;
> +            avdd-supply = <&avdd>;
> +            ldoin-supply = <&ldoin>;
> +            pwr-good-gpios = <&gpio 2 GPIO_ACTIVE_HIGH>;

[Severity: Low]
Does the missing #include <dt-bindings/gpio/gpio.h> here cause make
dt_binding_check to fail due to the unexpanded GPIO_ACTIVE_HIGH macro?

> +            adi,vout-rfb1-ohms = <10000>;
> +            adi,vout-rfb2-ohms = <2000>;
>          };
>      };
>  ...

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260720-dev-max20830c-v3-0-9d06d27d6da3@analog.com?part=1