From: sashiko-bot@kernel.org
To: XiaoYeZi <qaz6750@qq.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8150: Add slim nodes
Date: Mon, 20 Jul 2026 09:42:45 +0000 [thread overview]
Message-ID: <20260720094245.E2E4A1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <tencent_DF2E181B86AC588DD7B70DE904F6670BC207@qq.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added `slimbam` and `slim` device tree nodes are not sorted by their unit address, violating standard DT conventions.
--
--- Patch [1]: [PATCH] arm64: dts: qcom: sm8150: Add slim nodes ---
commit 47169c779220744d341492a384ae3d049c3c3c92
Author: XiaoYeZi <qaz6750@qq.com>
arm64: dts: qcom: sm8150: Add slim nodes
This commit adds the slimbus node which is an important node in audio.
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index 0e101096209ab..941043e0139a1 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -4410,6 +4410,18 @@ watchdog@17c10000 {
> interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>;
> };
>
> + slimbam: dma-controller@17184000 {
[Severity: Low]
This isn't a bug, but are these nodes placed out of order? Device tree nodes
within a bus are typically sorted alphanumerically by their unit address in
ascending order. The dma-controller@17184000 node is being inserted after
the watchdog@17c10000 node (17184000 < 17c10000). Should it be moved
earlier in the file?
[ ... ]
> @@ -4577,6 +4589,20 @@ cpufreq_hw: cpufreq@18323000 {
> #clock-cells = <1>;
> };
>
> + slim: slim-ngd@171c0000 {
[Severity: Low]
Similarly, the slim-ngd@171c0000 node is being placed after the
cpufreq@18323000 node (171c0000 < 18323000). Should this node also be placed
earlier to maintain standard unit-address sorting?
--
Sashiko AI review · https://sashiko.dev/#/patchset/tencent_DF2E181B86AC588DD7B70DE904F6670BC207@qq.com?part=1
next prev parent reply other threads:[~2026-07-20 9:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 9:33 [PATCH] arm64: dts: qcom: sm8150: Add slim nodes XiaoYeZi
2026-07-20 9:42 ` sashiko-bot [this message]
2026-07-20 10:05 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720094245.E2E4A1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=qaz6750@qq.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox