[PATCH] arm64: dts: qcom: sm8150: Add slim nodes

[PATCH] arm64: dts: qcom: sm8150: Add slim nodes

[XiaoYeZi]

The slimbus node is an important node in audio.

Signed-off-by: XiaoYeZi <qaz6750@qq.com>
---
 arch/arm64/boot/dts/qcom/sm8150.dtsi | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 661848ef5..2a83ba554 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -4410,6 +4410,18 @@ watchdog@17c10000 {
 			interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>;
 		};
 
+		slimbam: dma-controller@17184000 {
+			compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
+			qcom,controlled-remotely;
+			reg = <0 0x17184000 0 0x2c000>;
+			num-channels = <31>;
+			interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
+			#dma-cells = <1>;
+			qcom,ee = <1>;
+			qcom,num-ees = <2>;
+			iommus = <&apps_smmu 0x1b46 0x0>;
+		};
+
 		timer@17c20000 {
 			#address-cells = <1>;
 			#size-cells = <1>;
@@ -4577,6 +4589,20 @@ cpufreq_hw: cpufreq@18323000 {
 			#clock-cells = <1>;
 		};
 
+		slim: slim-ngd@171c0000 {
+			compatible = "qcom,slim-ngd-v2.1.0";
+			reg = <0 0x171c0000 0 0x2c000>;
+			interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
+
+			dmas = <&slimbam 3>, <&slimbam 4>;
+			dma-names = "rx", "tx";
+
+			iommus = <&apps_smmu 0x1b46 0x0>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
 		lmh_cluster1: lmh@18350800 {
 			compatible = "qcom,sm8150-lmh";
 			reg = <0 0x18350800 0 0x400>;
-- 
2.43.0

Re: [PATCH] arm64: dts: qcom: sm8150: Add slim nodes

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added `slimbam` and `slim` device tree nodes are not sorted by their unit address, violating standard DT conventions.
--

--- Patch [1]: [PATCH] arm64: dts: qcom: sm8150: Add slim nodes ---
commit 47169c779220744d341492a384ae3d049c3c3c92
Author: XiaoYeZi <qaz6750@qq.com>

arm64: dts: qcom: sm8150: Add slim nodes
    
This commit adds the slimbus node which is an important node in audio.

> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index 0e101096209ab..941043e0139a1 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -4410,6 +4410,18 @@ watchdog@17c10000 {
>  			interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>;
>  		};
>  
> +		slimbam: dma-controller@17184000 {

[Severity: Low]
This isn't a bug, but are these nodes placed out of order? Device tree nodes
within a bus are typically sorted alphanumerically by their unit address in
ascending order. The dma-controller@17184000 node is being inserted after
the watchdog@17c10000 node (17184000 < 17c10000). Should it be moved
earlier in the file?

[ ... ]

> @@ -4577,6 +4589,20 @@ cpufreq_hw: cpufreq@18323000 {
>  			#clock-cells = <1>;
>  		};
>  
> +		slim: slim-ngd@171c0000 {

[Severity: Low]
Similarly, the slim-ngd@171c0000 node is being placed after the
cpufreq@18323000 node (171c0000 < 18323000). Should this node also be placed
earlier to maintain standard unit-address sorting?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/tencent_DF2E181B86AC588DD7B70DE904F6670BC207@qq.com?part=1

Re: [PATCH] arm64: dts: qcom: sm8150: Add slim nodes

[Konrad Dybcio]

On 7/20/26 11:33 AM, XiaoYeZi wrote:
> The slimbus node is an important node in audio.

That is true, but this is not a great commit message. Please
check out:

https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

[...]

> +		slimbam: dma-controller@17184000 {
> +			compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
> +			qcom,controlled-remotely;
> +			reg = <0 0x17184000 0 0x2c000>;
> +			num-channels = <31>;
> +			interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
> +			#dma-cells = <1>;
> +			qcom,ee = <1>;
> +			qcom,num-ees = <2>;
> +			iommus = <&apps_smmu 0x1b46 0x0>;

Please assign the iommus values as the downstream kernel does, so
that all SIDs meant for the OS are assigned

Konrad