Re: [PATCH v17 1/4] dt-bindings: crypto: Document support for SPAcc

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The `reg` property size in the device tree example is incorrectly specified as 0x3ffff instead of 0x40000, representing an off-by-one error.
- [Low] The first sentence in the description block is a sentence fragment, and there is a missing space in the title.
--

--- Patch [1]: [PATCH v17 1/4] dt-bindings: crypto: Document support for SPAcc ---
commit 7ed8f2fc8bca4b54b48a471d2592cf36275dd72a
Author: Pavitrakumar Managutte <pavitrakumarm@vayavyalabs.com>

dt-bindings: crypto: Document support for SPAcc
    
Add DT bindings related to the SPAcc driver for Documentation.
DWC Synopsys Security Protocol Accelerator(SPAcc) Hardware Crypto
Engine is a crypto IP designed by Synopsys.

> diff --git a/Documentation/devicetree/bindings/crypto/snps,dwc-spacc.yaml b/Documentation/devicetree/bindings/crypto/snps,dwc-spacc.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/snps,dwc-spacc.yaml
[ ... ]
> +$id: http://devicetree.org/schemas/crypto/snps,dwc-spacc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Synopsys DesignWare Security Protocol Accelerator(SPAcc) Crypto Engine

[Severity: Low]
This isn't a bug, but is it intentional to omit the space before the 
parenthesis here?

> +
> +maintainers:
> +  - Ross Bannerman <rbannerm@synopsys.com>
> +
> +description: |
> +  The Synopsys DWC Security Protocol Accelerator (SPAcc), which is a
> +  semiconductor IP designed to accelerate cryptographic operations,
> +  such as encryption, decryption, and hashing.

[Severity: Low]
This isn't a bug, but this first sentence appears to be a fragment since it
uses a relative "which is" clause without a main verb. Could this be
rephrased for better readability?

[ ... ]
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    crypto@40000000 {
> +        compatible = "snps,nsimosci-hs-spacc";
> +        reg = <0x40000000 0x3ffff>;

[Severity: Low]
Does this reg size represent an off-by-one error? 

Device tree reg properties take <address length>, rather than 
<address max_offset>. If a 256 KB memory region is intended, should this size 
be 0x40000 instead of 0x3ffff?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260720113740.64960-1-pavitrakumarm@vayavyalabs.com?part=1