Re: [PATCH v17 4/4] crypto: spacc - Add SPAcc Kconfig and Makefile

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] CRYPTO_DEV_SPACC_HASH is defined as a tristate option but controls a component of a composite module, leading to an undefined reference linker error when configured as 'm' while the main driver is 'y'.
--

--- Patch [4]: [PATCH v17 4/4] crypto: spacc - Add SPAcc Kconfig and Makefile ---
commit 6d5d2ec49262f31f1558921632e08b8a62362a2d
Author: Pavitrakumar Managutte <pavitrakumarm@vayavyalabs.com>

crypto: spacc - Add SPAcc Kconfig and Makefile

Add Makefile and Kconfig for SPAcc driver.

> diff --git a/drivers/crypto/dwc-spacc/Kconfig b/drivers/crypto/dwc-spacc/Kconfig
> new file mode 100644
> index 0000000000000..edc550562235e
> --- /dev/null
> +++ b/drivers/crypto/dwc-spacc/Kconfig
> @@ -0,0 +1,83 @@
[ ... ]
> +if CRYPTO_DEV_SPACC
> +
> +config CRYPTO_DEV_SPACC_HASH
> +	tristate "Enable HASH functionality"

[Severity: Low]
Will this cause a build failure if CONFIG_CRYPTO_DEV_SPACC=y and
CONFIG_CRYPTO_DEV_SPACC_HASH=m?

Since CRYPTO_DEV_SPACC_HASH is a tristate, it can be set to 'm' while the
main driver is built-in ('y'). If that happens, Kbuild will add
spacc_ahash.o to snps-spacc-m in the Makefile:

    snps-spacc-$(CONFIG_CRYPTO_DEV_SPACC_HASH) += spacc_ahash.o

Because snps-spacc is built-in, Kbuild ignores the -m list, meaning
spacc_ahash.o won't be linked into the final kernel image. 

However, IS_ENABLED(CONFIG_CRYPTO_DEV_SPACC_HASH) evaluates to true for 'm' 
as well. This can lead to undefined reference errors when spacc_crypto_probe()
tries to call spacc_probe_hashes() and spacc_unregister_hash_algs() in
spacc_device.c.

Should CRYPTO_DEV_SPACC_HASH be a bool instead to prevent this mismatch?

> +	default CRYPTO_DEV_SPACC
> +	select CRYPTO_HASH
> +	select CRYPTO_SHA1
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260720113740.64960-1-pavitrakumarm@vayavyalabs.com?part=4