Re: [PATCH v16 10/12] media: dt-bindings: mediatek,jpeg: Add mediatek, mt8196-jpgenc compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Inaccurate documentation for the `iommus` property regarding the MT8196 SMMU change.
--

--- Patch [10]: [PATCH v16 10/12] media: dt-bindings: mediatek,jpeg: Add mediatek, mt8196-jpgenc compatible ---
commit 11c0f39e5d822c22a0e461d70a256b8d2035d561
Author: Kyrie Wu <kyrie.wu@mediatek.com>

media: dt-bindings: mediatek,jpeg: Add mediatek, mt8196-jpgenc compatible

This patch adds the mediatek,mt8196-jpgenc compatible string to the
MediaTek JPEG encoder binding. The commit message notes that the MT8196
uses an SMMU instead of an IOMMU.

> diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegenc.yaml b/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegenc.yaml
> --- a/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegenc.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegenc.yaml
> @@ -14,14 +14,16 @@ description:
>  
>  properties:
>    compatible:
> -    const: mediatek,mt8195-jpgenc
> +    enum:
> +      - mediatek,mt8195-jpgenc
> +      - mediatek,mt8196-jpgenc
>  
>    power-domains:
>      maxItems: 1
>  
>    iommus:
>      maxItems: 4
>      description:
>        Points to the respective IOMMU block with master port as argument, see
>        Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml for details.

[Severity: Low]
The commit message states that MT8196 uses an SMMU instead of an IOMMU, but the
documentation for properties.iommus still hardcodes references to
mediatek,iommu.yaml and specifies using a master port as argument.

Since SMMUs typically use stream IDs rather than master ports, does this
documentation regression need to be updated or generalized to remain accurate
for the newly added mt8196-jpgenc compatible?

[ ... ]

> @@ -44,14 +46,16 @@ patternProperties:
>  
>      properties:
>        compatible:
> -        const: mediatek,mt8195-jpgenc-hw
> +        enum:
> +          - mediatek,mt8195-jpgenc-hw
> +          - mediatek,mt8196-jpgenc-hw
>  
>        reg:
>          maxItems: 1
>  
>        iommus:
>          minItems: 1
>          maxItems: 32
>          description:
>            List of the hardware port in respective IOMMU block for current Socs.
>            Refer to bindings/iommu/mediatek,iommu.yaml.

[Severity: Low]
Similarly, the patternProperties.iommus description for the hardware nodes
still hardcodes the legacy mediatek,iommu.yaml reference.

Would it make sense to update this description as well to account for the
SMMU change described in the commit message?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260720133432.1042046-1-kyrie.wu@mediatek.com?part=10