From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Cc: Saravana Kannan <saravanak@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Test User <test@example.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel Golle <daniel@makrotopia.org>
Subject: Re: [PATCH v5 0/7] dtc: dt-check-style: Improvement after using on DTS
Date: Mon, 20 Jul 2026 15:51:57 -0500 [thread overview]
Message-ID: <20260720205157.GA4052473-robh@kernel.org> (raw)
In-Reply-To: <20260709-dts-style-checker-v5-0-fcc147cb697d@oss.qualcomm.com>
On Thu, Jul 09, 2026 at 07:41:28PM +0200, Krzysztof Kozlowski wrote:
> Changes in v5:
> 1. Patch #2, dtc: dt-check-style: Allow space-aligning indentation in
> DTS:
> Handle also line continuations for properties.
> 2. Update docs, other minor style/docs comments from Sashiko
> - Link to v4: https://patch.msgid.link/20260708-dts-style-checker-v4-0-c175e6401150@oss.qualcomm.com
>
> Changes in v4:
> 1. Drop patch:
> "dtc: dt-check-style: Do not sort top-level nodes in DTS by unit address"
> This needs more work.
> 2. Patch #1: Rename rule tab-in-dts to tab-in-yaml
> 3. Drop "memory@a0000000" in examples, because it messes with top-level
> sorting. Use a "cpus" node to test node and device_type property ordering.
> 4. Add more test-cases: within existing commits and a new patch at the
> end:
> "dtc: dt-check-style: Add more DTS test cases"
> 5. Handle #include and /include/ without trailing space
>
> Link to v3: https://patch.msgid.link/20260706-dts-style-checker-v3-0-03ffacff9226@oss.qualcomm.com
>
> Changes in v3:
> 1. Patch #2: Use re.search
> 2. Patch #2: Add dts-mixed-indent.dts test case
> 3. Several new patches 3-7.
> v2: https://lore.kernel.org/r/20260706102421.343639-4-krzysztof.kozlowski@oss.qualcomm.com/
>
> Changes in v2:
> 1. Patch #2: Rework idea.
> 2. Adjust function doc/comment.
> v1: https://lore.kernel.org/r/20260706071446.87669-2-krzysztof.kozlowski@oss.qualcomm.com/
>
> (I was not using b4 for v1 and v2, so b4 diff might fail)
>
> Best regards,
> Krzysztof
>
> ---
> Krzysztof Kozlowski (7):
> dtc: dt-check-style: Narrow disallowing of tab in DTS only to YAML
> dtc: dt-check-style: Allow space-aligning indentation in DTS
> dtc: dt-check-style: Rework handling YAML/DTS in rules
> dtc: dt-check-style: Expect first device_type
> dtc: dt-check-style: Handle properly DTC-style includes
> dtc: dt-check-style: Print proper line number of indentation detection place
> dtc: dt-check-style: Add more DTS test cases
Applied. Send a follow-up if the sashiko report is valid.
Rob
prev parent reply other threads:[~2026-07-20 20:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 17:41 [PATCH v5 0/7] dtc: dt-check-style: Improvement after using on DTS Krzysztof Kozlowski
2026-07-09 17:41 ` [PATCH v5 1/7] dtc: dt-check-style: Narrow disallowing of tab in DTS only to YAML Krzysztof Kozlowski
2026-07-09 17:41 ` [PATCH v5 2/7] dtc: dt-check-style: Allow space-aligning indentation in DTS Krzysztof Kozlowski
2026-07-09 18:01 ` sashiko-bot
2026-07-09 17:41 ` [PATCH v5 3/7] dtc: dt-check-style: Rework handling YAML/DTS in rules Krzysztof Kozlowski
2026-07-09 17:41 ` [PATCH v5 4/7] dtc: dt-check-style: Expect first device_type Krzysztof Kozlowski
2026-07-09 17:41 ` [PATCH v5 5/7] dtc: dt-check-style: Handle properly DTC-style includes Krzysztof Kozlowski
2026-07-09 17:41 ` [PATCH v5 6/7] dtc: dt-check-style: Print proper line number of indentation detection place Krzysztof Kozlowski
2026-07-09 17:41 ` [PATCH v5 7/7] dtc: dt-check-style: Add more DTS test cases Krzysztof Kozlowski
2026-07-20 20:51 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720205157.GA4052473-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=saravanak@kernel.org \
--cc=test@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox