From: sashiko-bot@kernel.org
To: "Taniya Das" <taniya.das@oss.qualcomm.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 5/6] dt-bindings: clock: qcom: Document Nord GPU clock controllers
Date: Tue, 21 Jul 2026 07:14:19 +0000 [thread overview]
Message-ID: <20260721071419.CA2FD1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260721-nords_mm_v1-v2-5-17e5a445a512@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added header file `qcom,nord-gpu2cc.h` is missing from the `See also:` description list in the binding YAML.
--
--- Patch [5]: [PATCH v2 5/6] dt-bindings: clock: qcom: Document Nord GPU clock controllers ---
commit 478c81620fe4a48a58e658fce1f3422dbf8f168b
Author: Taniya Das <taniya.das@oss.qualcomm.com>
dt-bindings: clock: qcom: Document Nord GPU clock controllers
This commit adds Device Tree binding documentation for the GPU clock controllers
on the Qualcomm Nord platform. It introduces compatible strings and header
files for both the GPUCC and GPUCC2 instances.
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-gpucc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-gpucc.yaml
> index fdbdf605ee695..ba85692240e07 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-gpucc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-gpucc.yaml
> @@ -18,6 +18,7 @@ description: |
> include/dt-bindings/clock/qcom,glymur-gpucc.h
> include/dt-bindings/clock/qcom,kaanapali-gpucc.h
> include/dt-bindings/clock/qcom,milos-gpucc.h
> + include/dt-bindings/clock/qcom,nord-gpucc.h
[Severity: Low]
This isn't a bug, but since this patch adds support for both GPUCC and
GPUCC2, should include/dt-bindings/clock/qcom,nord-gpu2cc.h also be added
to this description list alongside qcom,nord-gpucc.h?
> include/dt-bindings/clock/qcom,sar2130p-gpucc.h
> include/dt-bindings/clock/qcom,sm4450-gpucc.h
> include/dt-bindings/clock/qcom,sm8450-gpucc.h
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-nords_mm_v1-v2-0-17e5a445a512@oss.qualcomm.com?part=5
next prev parent reply other threads:[~2026-07-21 7:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 7:07 [PATCH v2 0/6] clk: qcom: Add Nord multimedia clock controller support Taniya Das
2026-07-21 7:07 ` [PATCH v2 1/6] clk: qcom: gcc-nord: mark PCIe link clocks as critical Taniya Das
2026-07-21 7:07 ` [PATCH v2 2/6] clk: qcom: negcc-nord: keep GPU2 CFG clock enabled via critical CBCR Taniya Das
2026-07-21 7:07 ` [PATCH v2 3/6] dt-bindings: clock: qcom: Document Nord display clock controller Taniya Das
2026-07-21 7:07 ` [PATCH v2 4/6] clk: qcom: Add Nord display clock controller support Taniya Das
2026-07-21 7:07 ` [PATCH v2 5/6] dt-bindings: clock: qcom: Document Nord GPU clock controllers Taniya Das
2026-07-21 7:14 ` sashiko-bot [this message]
2026-07-21 7:07 ` [PATCH v2 6/6] clk: qcom: gpucc: Add Nord graphics clock controller support Taniya Das
2026-07-21 7:18 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721071419.CA2FD1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox