Re: [PATCH v2 6/6] clk: qcom: gpucc: Add Nord graphics clock controller support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `gpu_2_cc_hub_clk_src` clock incorrectly reuses the frequency table for `gpu_2_cc_ff_clk_src`.
--

--- Patch [6]: [PATCH v2 6/6] clk: qcom: gpucc: Add Nord graphics clock controller support ---
commit 09ee5a90eabdc23a86ad541e2815981623d9e1fe
Author: Taniya Das <taniya.das@oss.qualcomm.com>

clk: qcom: gpucc: Add Nord graphics clock controller support

This commit adds support for the GPU and GPU2 clock controllers on the
Qualcomm Nord platform. These controllers provide the clocks required for
the graphics subsystem.

> diff --git a/drivers/clk/qcom/gpu2cc-nord.c b/drivers/clk/qcom/gpu2cc-nord.c
> new file mode 100644
> index 0000000000000..a05ff9fa1506e
> --- /dev/null
> +++ b/drivers/clk/qcom/gpu2cc-nord.c

[ ... ]

> +static struct clk_rcg2 gpu_2_cc_hub_clk_src = {
> +	.cmd_rcgr = 0x91a8,
> +	.mnd_width = 0,
> +	.hid_width = 5,
> +	.parent_map = gpu_2_cc_parent_map_2,
> +	.freq_tbl = ftbl_gpu_2_cc_ff_clk_src,

[Severity: Medium]
Is this frequency table correct? It looks like gpu_2_cc_hub_clk_src is
reusing the ftbl_gpu_2_cc_ff_clk_src table (200 MHz), rather than having
its own dedicated frequency table. 

In gpucc-nord.c, the equivalent hub clock has its own table configured for
300 MHz. Will this reuse cause the GPU2 hub to be underclocked when the
GPU2 subsystem requests its hub clock rate?

> +	.hw_clk_ctrl = true,
> +	.clkr.hw.init = &(const struct clk_init_data) {
> +		.name = "gpu_2_cc_hub_clk_src",
> +		.parent_data = gpu_2_cc_parent_data_2,
> +		.num_parents = ARRAY_SIZE(gpu_2_cc_parent_data_2),
> +		.flags = CLK_SET_RATE_PARENT,
> +		.ops = &clk_rcg2_shared_ops,
> +	},
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-nords_mm_v1-v2-0-17e5a445a512@oss.qualcomm.com?part=6