[PATCH v2 0/3] arm64: dts: qcom: eliza: Add CDSP support and enable it on MTP and CQS SoM

[PATCH v2 0/3] arm64: dts: qcom: eliza: Add CDSP support and enable it on MTP and CQS SoM

[Abel Vesa]

Describe the CDSP node and the related SMP2P, then enable the CDSP on
both the MTP and CQS SoM.

Driver support and bindings update are here:
https://lore.kernel.org/all/20260721-remoteproc-eliza-cdsp-v2-0-f3345405e4da@oss.qualcomm.com/

Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
Changes in v2:
- Rebased on next-20260720
- Picked up Konrad's R-b tags.
- Link to v1: https://patch.msgid.link/20260714-dts-qcom-eliza-add-cdsp-v1-0-525e757a23b0@oss.qualcomm.com

---
Abel Vesa (3):
      arm64: dts: qcom: eliza: Describe the CDSP remoteproc
      arm64: dts: qcom: eliza-mtp: Enable CDSP remoteproc
      arm64: dts: qcom: eliza-cqs-som: Enable CDSP remoteproc

 arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi |  7 ++++
 arch/arm64/boot/dts/qcom/eliza-mtp.dts      |  7 ++++
 arch/arm64/boot/dts/qcom/eliza.dtsi         | 64 +++++++++++++++++++++++++++++
 3 files changed, 78 insertions(+)
---
base-commit: 3fe08b9796f36ef437ab9328e7dd1e5ff2d66603
change-id: 20260714-dts-qcom-eliza-add-cdsp-0288fd79c8c2

Best regards,
--  
Abel Vesa <abel.vesa@oss.qualcomm.com>

[PATCH v2 1/3] arm64: dts: qcom: eliza: Describe the CDSP remoteproc

[Abel Vesa]

Describe the CDSP remoteproc along with the related SMP2P.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/eliza.dtsi | 64 +++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
index 357e8066c176..0c6fdfc5a4cc 100644
--- a/arch/arm64/boot/dts/qcom/eliza.dtsi
+++ b/arch/arm64/boot/dts/qcom/eliza.dtsi
@@ -626,6 +626,30 @@ smp2p_adsp_in: slave-kernel {
 		};
 	};
 
+	smp2p-cdsp {
+		compatible = "qcom,smp2p";
+		qcom,smem = <94>, <432>;
+		interrupts-extended = <&ipcc IPCC_CLIENT_CDSP
+					     IPCC_MPROC_SIGNAL_SMP2P
+					     IRQ_TYPE_EDGE_RISING>;
+		mboxes = <&ipcc IPCC_CLIENT_CDSP
+				IPCC_MPROC_SIGNAL_SMP2P>;
+
+		qcom,local-pid = <0>;
+		qcom,remote-pid = <5>;
+
+		smp2p_cdsp_out: master-kernel {
+			qcom,entry-name = "master-kernel";
+			#qcom,smem-state-cells = <1>;
+		};
+
+		smp2p_cdsp_in: slave-kernel {
+			qcom,entry-name = "slave-kernel";
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+	};
+
 	soc: soc@0 {
 		compatible = "simple-bus";
 
@@ -3737,6 +3761,46 @@ nsp_noc: interconnect@320c0000 {
 			qcom,bcm-voters = <&apps_bcm_voter>;
 			#interconnect-cells = <2>;
 		};
+
+		remoteproc_cdsp: remoteproc@32300000 {
+			compatible = "qcom,eliza-cdsp-pas";
+			reg = <0x0 0x32300000 0x0 0x10000>;
+
+			interrupts-extended = <&intc GIC_SPI 578 IRQ_TYPE_EDGE_RISING>,
+					      <&smp2p_cdsp_in 0 IRQ_TYPE_EDGE_RISING>,
+					      <&smp2p_cdsp_in 1 IRQ_TYPE_EDGE_RISING>,
+					      <&smp2p_cdsp_in 2 IRQ_TYPE_EDGE_RISING>,
+					      <&smp2p_cdsp_in 3 IRQ_TYPE_EDGE_RISING>,
+					      <&smp2p_cdsp_in 7 IRQ_TYPE_EDGE_RISING>;
+			interrupt-names = "wdog",
+					  "fatal",
+					  "ready",
+					  "handover",
+					  "stop-ack",
+					  "shutdown-ack";
+
+			clocks = <&rpmhcc RPMH_CXO_CLK>;
+			clock-names = "xo";
+
+			power-domains = <&rpmhpd RPMHPD_CX>,
+					<&rpmhpd RPMHPD_MX>,
+					<&rpmhpd RPMHPD_NSP>;
+			power-domain-names = "cx",
+					     "mx",
+					     "nsp";
+
+			interconnects = <&nsp_noc MASTER_CDSP_PROC QCOM_ICC_TAG_ALWAYS
+					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
+
+			memory-region = <&cdsp_mem>, <&q6_cdsp_dtb_mem>, <&global_sync_mem>;
+
+			qcom,qmp = <&aoss_qmp>;
+
+			qcom,smem-states = <&smp2p_cdsp_out 0>;
+			qcom,smem-state-names = "stop";
+
+			status = "disabled";
+		};
 	};
 
 	thermal-zones {

-- 
2.54.0

[PATCH v2 2/3] arm64: dts: qcom: eliza-mtp: Enable CDSP remoteproc

[Abel Vesa]

Enable the CDSP remoteproc node on the Eliza MTP by providing the firmware
names and marking the node as available.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/eliza-mtp.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/eliza-mtp.dts b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
index 5abc23b9b676..c5a772b05223 100644
--- a/arch/arm64/boot/dts/qcom/eliza-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
@@ -484,6 +484,13 @@ &remoteproc_adsp {
 	status = "okay";
 };
 
+&remoteproc_cdsp {
+	firmware-name = "qcom/eliza/cdsp.mbn",
+			"qcom/eliza/cdsp_dtb.mbn";
+
+	status = "okay";
+};
+
 &spi8 {
 	status = "okay";
 

-- 
2.54.0

[PATCH v2 3/3] arm64: dts: qcom: eliza-cqs-som: Enable CDSP remoteproc

[Abel Vesa]

Enable the CDSP remoteproc node on the Eliza CQS SoM by providing the
firmware names and marking the node as available.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi b/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
index 318ae3c22351..d31267968cad 100644
--- a/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
+++ b/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
@@ -376,6 +376,13 @@ &remoteproc_adsp {
 	status = "okay";
 };
 
+&remoteproc_cdsp {
+	firmware-name = "qcom/eliza/cdsp.mbn",
+			"qcom/eliza/cdsp_dtb.mbn";
+
+	status = "okay";
+};
+
 &sdhc_1 {
 	vmmc-supply = <&vreg_l12b>;
 	vqmmc-supply = <&vreg_l1d>;

-- 
2.54.0

Re: [PATCH v2 1/3] arm64: dts: qcom: eliza: Describe the CDSP remoteproc

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `remoteproc_cdsp` node lacks the `glink-edge` subnode required for inter-processor communication.
--

--- Patch [1]: [PATCH v2 1/3] arm64: dts: qcom: eliza: Describe the CDSP remoteproc ---
commit 0d8a8296d1e008af4feca584273c5028b5ea34a2
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: eliza: Describe the CDSP remoteproc

This commit introduces the CDSP remoteproc and its related SMP2P node.
It provisions the device tree nodes, interrupts, clocks, and power
domains necessary for the DSP.

> diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
> --- a/arch/arm64/boot/dts/qcom/eliza.dtsi
> +++ b/arch/arm64/boot/dts/qcom/eliza.dtsi
[ ... ]
> @@ -3737,6 +3761,46 @@ nsp_noc: interconnect@320c0000 {
>  			qcom,bcm-voters = <&apps_bcm_voter>;
>  			#interconnect-cells = <2>;
>  		};
> +
> +		remoteproc_cdsp: remoteproc@32300000 {
> +			compatible = "qcom,eliza-cdsp-pas";
> +			reg = <0x0 0x32300000 0x0 0x10000>;

[Severity: Medium]
Does this node also need a glink-edge subnode?

Without the glink-edge subnode and a fastrpc child, it appears the
application processor might not be able to establish GLINK/IPCC message
channels with the CDSP. Will this prevent the DSP from receiving
workloads from the host when the node is eventually enabled?

> +
> +			interrupts-extended = <&intc GIC_SPI 578 IRQ_TYPE_EDGE_RISING>,
> +					      <&smp2p_cdsp_in 0 IRQ_TYPE_EDGE_RISING>,
> +					      <&smp2p_cdsp_in 1 IRQ_TYPE_EDGE_RISING>,
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-dts-qcom-eliza-add-cdsp-v2-0-e1e52bfb3c12@oss.qualcomm.com?part=1

Re: [PATCH v2 2/3] arm64: dts: qcom: eliza-mtp: Enable CDSP remoteproc

[Dmitry Baryshkov]

On Tue, Jul 21, 2026 at 11:25:49AM +0300, Abel Vesa wrote:
> Enable the CDSP remoteproc node on the Eliza MTP by providing the firmware
> names and marking the node as available.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/eliza-mtp.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Re: [PATCH v2 3/3] arm64: dts: qcom: eliza-cqs-som: Enable CDSP remoteproc

[Dmitry Baryshkov]

On Tue, Jul 21, 2026 at 11:25:50AM +0300, Abel Vesa wrote:
> Enable the CDSP remoteproc node on the Eliza CQS SoM by providing the
> firmware names and marking the node as available.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Re: [PATCH v2 1/3] arm64: dts: qcom: eliza: Describe the CDSP remoteproc

[Dmitry Baryshkov]

On Tue, Jul 21, 2026 at 11:25:48AM +0300, Abel Vesa wrote:
> Describe the CDSP remoteproc along with the related SMP2P.

Why is there no glink-edge / FastRPC? They might be not yet supported,
but please mention it in the commit message. GLINK should probably work.

> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/eliza.dtsi | 64 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 64 insertions(+)
> 
> 

-- 
With best wishes
Dmitry

Re: [PATCH v2 1/3] arm64: dts: qcom: eliza: Describe the CDSP remoteproc

[Abel Vesa]

On 26-07-22 01:30:27, Dmitry Baryshkov wrote:
> On Tue, Jul 21, 2026 at 11:25:48AM +0300, Abel Vesa wrote:
> > Describe the CDSP remoteproc along with the related SMP2P.
> 
> Why is there no glink-edge / FastRPC? They might be not yet supported,
> but please mention it in the commit message. GLINK should probably work.

I'll include the glink-edge in this patch.

The FastPRC was sent separately, later, because it wasn't tested in time
to be sent together. Mentioned here:
https://lore.kernel.org/all/20260721-dts-qcom-eliza-add-fastrpc-v1-1-cbea68d8e01b@oss.qualcomm.com/

I don't think commit message should talk about future work though.

Re: [PATCH v2 1/3] arm64: dts: qcom: eliza: Describe the CDSP remoteproc

[Dmitry Baryshkov]

On Wed, Jul 22, 2026 at 02:01:27PM +0300, Abel Vesa wrote:
> On 26-07-22 01:30:27, Dmitry Baryshkov wrote:
> > On Tue, Jul 21, 2026 at 11:25:48AM +0300, Abel Vesa wrote:
> > > Describe the CDSP remoteproc along with the related SMP2P.
> > 
> > Why is there no glink-edge / FastRPC? They might be not yet supported,
> > but please mention it in the commit message. GLINK should probably work.
> 
> I'll include the glink-edge in this patch.
> 
> The FastPRC was sent separately, later, because it wasn't tested in time
> to be sent together. Mentioned here:
> https://lore.kernel.org/all/20260721-dts-qcom-eliza-add-fastrpc-v1-1-cbea68d8e01b@oss.qualcomm.com/
> 
> I don't think commit message should talk about future work though.


I would not 100% agree here. It simplifies work of the reviewers. If I
see a DSP w/o glink or FastRPC, I need to think why it is not present.
Is it something which doesn't have GLINK support? Or are there any other
issues? While stating that abc will be done later saves us from those
questions.

For me it's similar to the USB support. It's not infrequent to get only
host or only peripheral supported in the first patch. But the commit
message needs to specify if it's a hardware limitation, a software
limiation or something which wasn't done yet.

-- 
With best wishes
Dmitry