Re: [PATCH v2 3/6] dt-bindings: hwmon: Add Sensylink CTF2301

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `sensylink,ctf2301` compatible string is added to a flat `enum` instead of allowing a fallback, preventing the device from using existing driver support.
--

--- Patch [3]: [PATCH v2 3/6] dt-bindings: hwmon: Add Sensylink CTF2301 ---
commit 2d1df9d4d4d9fa27f7828b7715766842a51c0154
Author: Troy Mitchell <troy.mitchell@linux.dev>
Subject: dt-bindings: hwmon: Add Sensylink CTF2301

This commit adds the Sensylink CTF2301 temperature sensor and fan controller
to the LM63 family binding. It updates the device tree schema to accept the
new compatible string.

> diff --git a/Documentation/devicetree/bindings/hwmon/national,lm63.yaml b/Documentation/devicetree/bindings/hwmon/national,lm63.yaml
> index 92b0094ff3034..4a1ffebfdbef6 100644
> --- a/Documentation/devicetree/bindings/hwmon/national,lm63.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/national,lm63.yaml
[ ... ]
> @@ -23,6 +24,7 @@ properties:
>        - national,lm63
>        - national,lm64
>        - national,lm96163
> +      - sensylink,ctf2301

[Severity: Medium]
Since the commit message mentions this device follows the LM63 register
model, should this compatible string allow a fallback to "national,lm63"
instead of being added to this flat enum?

Without a fallback, and since no driver update is included to add the new
ID, could this cause a regression where the existing Linux driver fails to
match and probe the device when a device tree specifies only
"sensylink,ctf2301"?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-ctl2301-v2-0-ef5fb342872a@linux.dev?part=3