Re: [PATCH v2 5/6] riscv: dts: spacemit: Add K3 I2C6 pinctrl state

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `drive-strength` value `18` is invalid according to the SpacemiT K3 pinctrl binding schema, causing `dtbs_check` validation failures.
--

--- Patch [5]: [PATCH v2 5/6] riscv: dts: spacemit: Add K3 I2C6 pinctrl state ---
commit 7b36908eb32982b060ee59a7f9ad3d2f49fdd88e
Author: Troy Mitchell <troy.mitchell@linux.dev>

riscv: dts: spacemit: Add K3 I2C6 pinctrl state

This commit adds the I2C6 pinctrl state for K3 boards that route to pads 7 
and 8, omitting the board-specific IO voltage selection.

> diff --git a/arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi b/arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi
> index 3ee1471f37985..91cd08099e276 100644
> --- a/arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi
> @@ -78,6 +78,17 @@ gmac1-phy-0-pins {

[ ... ]

> +	/omit-if-no-ref/
> +	i2c6_1_cfg: i2c6-1-cfg {
> +		i2c6-1-pins {
> +			pinmux = <K3_PADCONF(7, 6)>,	/* i2c6 scl */
> +				 <K3_PADCONF(8, 6)>;	/* i2c6 sda */
> +
> +			bias-pull-up = <0>;
> +			drive-strength = <18>;

[Severity: Low]
Is this drive-strength value supported by the binding? The value 18 doesn't
appear to be valid according to the SpacemiT K3 pinctrl binding schema
(spacemit,k1-pinctrl.yaml), which triggers a dtbs_check validation failure.

Since the driver's spacemit_get_ds_value() will silently fall back to the 
next highest valid value (like 21mA or 25mA depending on voltage), could 
this cause an unexpected mismatch between the requested devicetree state 
and the actual hardware configuration?

> +		};
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-ctl2301-v2-0-ef5fb342872a@linux.dev?part=5