Re: [PATCH v6 5/5] arm64: dts: qcom: sm8650-hdk: add SPMI ADC channels and thermal nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The Device Tree unit-address for the PM8550VE ADC channel node does not match its evaluated 'reg' property value, triggering a dtc warning.
- [Low] The patch series relies on an uncommitted header file ('qcom-adc5-gen3.h'), resulting in a build failure.
--

--- Patch [5]: [PATCH v6 5/5] arm64: dts: qcom: sm8650-hdk: add SPMI ADC channels and thermal nodes ---
commit 0f6771497277cdb9e2028ce4ba0b81d340cf6283
Author: Neil Armstrong <neil.armstrong@linaro.org>

arm64: dts: qcom: sm8650-hdk: add SPMI ADC channels and thermal nodes

Add the SPMI ADC channels on the PMK8550 SPMI5 ADC3 for the
other PMICS on the system.

The thermal nodes are sorted by the sensor channel to be
coherent with the system thermal nodes ordering.

> diff --git a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts
> index eabc828c05b4c..2d6be57a2a80a 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts

[ ... ]

> +&pm8550_temp_alarm {
> +	io-channels = <&pmk8550_vadc ADC5_GEN3_DIE_TEMP(1)>;

[Severity: Low]
Is there a missing header dependency for this patch series?

It looks like ADC5_GEN3_DIE_TEMP() is being used as a function-like macro
here, which appears to rely on a qcom-adc5-gen3.h header that might not be
included in this series. Does this cause a build failure during dtbs
compilation?

> +	io-channel-names = "thermal";
> +};

[ ... ]

> +	/* PM8550VE Channel nodes */
> +	channel@503 {
> +		reg = <ADC5_GEN3_DIE_TEMP(PMK8550VE_SID)>;

[Severity: Low]
Does this unit-address match the evaluated register address?

Assuming PMK8550VE_SID is 8, ADC5_GEN3_DIE_TEMP(PMK8550VE_SID) would likely
evaluate to 0x803. If so, should the node name be updated to channel@803 to
match the reg property and avoid a Device Tree compiler warning?

> +		label = "pm8550ve_die_temp";
> +		qcom,pre-scaling = <1 1>;
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-topic-sm8x50-adc5-gen3-v6-0-a507f4a1e537@linaro.org?part=5