Re: [PATCH V19 9/9] arm64: dts: rockchip: Add icm42607p IMU for RG-DS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing power supply properties (vdd-supply and vddio-supply) in the device tree node.
--

--- Patch [9]: [PATCH V19 9/9] arm64: dts: rockchip: Add icm42607p IMU for RG-DS ---
commit 05126f7b1858f1ad978be9793e857272c00e7b8f
Author: Chris Morgan <macromorgan@hotmail.com>
Subject: arm64: dts: rockchip: Add icm42607p IMU for RG-DS

This commit adds the Invensense ICM42607P IMU node to the Anbernic RG-DS
device tree.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-anbernic-rg-ds.dts b/arch/arm64/boot/dts/rockchip/rk3568-anbernic-rg-ds.dts
> index 8d906ab02c5fb..b770bfd5268d8 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-anbernic-rg-ds.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-anbernic-rg-ds.dts
> @@ -871,7 +871,13 @@ aw87391_pa_r: audio-codec@5b {
>  		sound-name-prefix = "Right Amp";
>  	};
>  
> -	/* invensense,icm42607p at 0x68 */
> +	icm42607p: imu@68 {
> +		compatible = "invensense,icm42607p";
> +		reg = <0x68>;
> +		mount-matrix = "-1", "0", "0",
> +			       "0", "1", "0",
> +			       "0", "0", "-1";
> +	};

[Severity: Low]
Are the vdd-supply and vddio-supply properties missing for this node?

The inv_icm42607 driver unconditionally requests vdd and vddio regulators via
devm_regulator_get_enable() during probe. Without these explicitly defined in
the device tree, the framework will fall back to dummy regulators.

While the driver will still probe successfully, this incomplete hardware
description could cause the IMU to lose power unexpectedly if the shared
physical regulator is ever turned off by another subsystem.

>  };
>  
>  &i2c3 {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260722153942.144387-1-macroalpha82@gmail.com?part=9