[PATCH v2] dt-bindings: usb: ti,da830-ohci: Convert to DT schema

[PATCH v2] dt-bindings: usb: ti,da830-ohci: Convert to DT schema

[Bhargav Joshi]

Convert Texas Instruments da830-ohci bindings from legacy text to DT
schema. Name of binding is changed to match primary compatible property.
Add required property clocks and optional property oc-gpios which were
missing from legacy binding.

Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
Changes in v2:
- Added clocks as required property which was missing in legacy binding.
- Added oc-gpios property which is checked by driver.
- Link to v1: https://patch.msgid.link/20260717-ti-da830-ohci-v1-1-3f2d111a2042@gmail.com
---
 .../devicetree/bindings/usb/ohci-da8xx.txt         | 23 ---------
 .../devicetree/bindings/usb/ti,da830-ohci.yaml     | 58 ++++++++++++++++++++++
 2 files changed, 58 insertions(+), 23 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/ohci-da8xx.txt b/Documentation/devicetree/bindings/usb/ohci-da8xx.txt
deleted file mode 100644
index 24a826d5015e..000000000000
--- a/Documentation/devicetree/bindings/usb/ohci-da8xx.txt
+++ /dev/null
@@ -1,23 +0,0 @@
-DA8XX USB OHCI controller
-
-Required properties:
-
- - compatible: Should be "ti,da830-ohci"
- - reg:        Should contain one register range i.e. start and length
- - interrupts: Description of the interrupt line
- - phys:       Phandle for the PHY device
- - phy-names:  Should be "usb-phy"
-
-Optional properties:
- - vbus-supply: phandle of regulator that controls vbus power / over-current
-
-Example:
-
-ohci: usb@225000 {
-        compatible = "ti,da830-ohci";
-        reg = <0x225000 0x1000>;
-        interrupts = <59>;
-        phys = <&usb_phy 1>;
-        phy-names = "usb-phy";
-        vbus-supply = <&reg_usb_ohci>;
-};
diff --git a/Documentation/devicetree/bindings/usb/ti,da830-ohci.yaml b/Documentation/devicetree/bindings/usb/ti,da830-ohci.yaml
new file mode 100644
index 000000000000..f7b9db6347fa
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/ti,da830-ohci.yaml
@@ -0,0 +1,58 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/ti,da830-ohci.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: DA8XX USB OHCI controller
+
+maintainers:
+  - Axel Haslam <ahaslam@baylibre.com>
+
+properties:
+  compatible:
+    const: ti,da830-ohci
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  phys:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  phy-names:
+    const: usb-phy
+
+  vbus-supply:
+    description:
+      phandle of regulator that controls vbus power / over-current
+
+  oc-gpios:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - phys
+  - phy-names
+  - clocks
+
+additionalProperties: false
+
+examples:
+  - |
+    usb@225000 {
+        compatible = "ti,da830-ohci";
+        reg = <0x225000 0x1000>;
+        interrupts = <59>;
+        phys = <&usb_phy 1>;
+        phy-names = "usb-phy";
+        clocks = <&psc1 2>;
+        vbus-supply = <&reg_usb_ohci>;
+    };

---
base-commit: ef0c9f75a19532d7675384708fc8621e10850104
change-id: 20260622-ti-da830-ohci-2a2299d045e2

Best regards,
-- 
Bhargav

Re: [PATCH v2] dt-bindings: usb: ti,da830-ohci: Convert to DT schema

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The DT schema does not reference the common USB HCD schema (usb-hcd.yaml) and restricts properties with `additionalProperties: false`.
--

--- Patch [1]: [PATCH v2] dt-bindings: usb: ti,da830-ohci: Convert to DT schema ---
commit 71d5f694a3c66084670958199c0d6e277f1f74e5
Author: Bhargav Joshi <j.bhargav.u@gmail.com>
Date:   Thu Jul 23 15:43:29 2026 +0000

dt-bindings: usb: ti,da830-ohci: Convert to DT schema

Convert Texas Instruments da830-ohci bindings from legacy text to DT schema. 
Name of binding is changed to match primary compatible property. Add required 
property clocks and optional property oc-gpios which were missing from legacy 
binding.

Link: https://patch.msgid.link/20260717-ti-da830-ohci-v1-1-3f2d111a2042@gmail.com

> diff --git a/Documentation/devicetree/bindings/usb/ti,da830-ohci.yaml b/Documentation/devicetree/bindings/usb/ti,da830-ohci.yaml
> new file mode 100644
> index 0000000000000..f7b9db6347fab
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ti,da830-ohci.yaml

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - phys
> +  - phy-names
> +  - clocks
> +
> +additionalProperties: false

[Severity: Low]
Should this schema include a $ref to usb-hcd.yaml#?

Since additionalProperties is set to false, omitting the reference to the
common USB host controller schema means that any valid addition of standard 
USB properties (such as #address-cells, #size-cells, or companion) will 
result in dt_binding_check failures.

> +
> +examples:
> +  - |
> +    usb@225000 {
> +        compatible = "ti,da830-ohci";
> +        reg = <0x225000 0x1000>;
> +        interrupts = <59>;
> +        phys = <&usb_phy 1>;
> +        phy-names = "usb-phy";
> +        clocks = <&psc1 2>;
> +        vbus-supply = <&reg_usb_ohci>;
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260723-ti-da830-ohci-v2-1-41e54afc4703@gmail.com?part=1