Re: [PATCH v3 3/4] clk: qcom: Add Audio Core clock controller support on Qualcomm Shikra SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `audio_core_cc_shikra_probe` function does not validate the return value of `device_get_match_data()`, leading to a NULL pointer dereference.
--

--- Patch [3]: [PATCH v3 3/4] clk: qcom: Add Audio Core clock controller support on Qualcomm Shikra SoC ---
commit de62912fa52410c163e6ab3071a5cbf9cc2887aa
Author: Imran Shaik <imran.shaik@oss.qualcomm.com>

clk: qcom: Add Audio Core clock controller support on Qualcomm Shikra SoC

This commit adds support for the Audio Core Clock Controller (AUDIOCORECC)
and Audio Core CSR resets on the Qualcomm Shikra SoC.

> diff --git a/drivers/clk/qcom/audiocorecc-shikra.c b/drivers/clk/qcom/audiocorecc-shikra.c
> new file mode 100644
> index 0000000000000..76017240f7684
> --- /dev/null
> +++ b/drivers/clk/qcom/audiocorecc-shikra.c
[ ... ]
> +static int audio_core_cc_shikra_probe(struct platform_device *pdev)
> +{
> +	const struct qcom_cc_desc *desc;
> +
> +	desc = device_get_match_data(&pdev->dev);
> +
> +	return qcom_cc_probe(pdev, desc);

[Severity: High]
Can this result in a NULL pointer dereference? If the driver is bound to a
device via the driver_override sysfs attribute, device_get_match_data()
will return NULL because the OF match fails.

The NULL desc pointer is then passed unchecked to qcom_cc_probe(), which
calls qcom_cc_map(pdev, desc), leading to a dereference of desc->config.

Should there be a NULL check for desc before passing it to qcom_cc_probe()?

> +}
> +
> +static struct platform_driver audio_core_cc_shikra_driver = {
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260723-shikra-audiocorecc-v3-0-90b878ae0d4e@oss.qualcomm.com?part=3