* [PATCH V4 1/4] arm64: dts: qcom: glymur-crd: Update VREG l2b_e0 and l9b_e0 voltage for SD-card
2026-07-22 14:23 [PATCH V4 0/4] arm64: dts: qcom: Add SD card support for Glymur Monish Chunara
@ 2026-07-22 14:23 ` Monish Chunara
2026-07-22 14:23 ` [PATCH V4 2/4] dt-bindings: mmc: sdhci-msm: Document the Glymur compatible Monish Chunara
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Monish Chunara @ 2026-07-22 14:23 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dmitry Baryshkov
Cc: Nitin Rawat, Pradeep Pragallapati, Komal Bajaj, Sachin Rathore,
Monish Chunara, linux-arm-msm, devicetree, linux-kernel,
Kamal Wadhwa, Konrad Dybcio
From: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
SD cards may need 1.8v VDDIO also to be supported, to accommodate this
requirement reduce the min voltage to 1.8v for `vreg_l2b_e0` which
supplies to VDDIO pin of SD card.
NOTE - Since this SD card is the only client on this regulator, this
change should not have any side effect on any other clients.
moreover, SD card driver takes care to explicitly vote for the
regulator voltage based on the SD card detection sequence.
Also for stable operation of the SD card increase VDD voltage
supplied by `vreg_l9b_e0` to 2.96v.
Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/glymur-crd.dtsi | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
index b314c6dd423c..2e41b4ec83a5 100644
--- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
+++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
@@ -373,7 +373,7 @@ vreg_l1b_e0_1p8: ldo1 {
vreg_l2b_e0_2p9: ldo2 {
regulator-name = "vreg_l2b_e0_2p9";
- regulator-min-microvolt = <2904000>;
+ regulator-min-microvolt = <1804000>;
regulator-max-microvolt = <2904000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};
@@ -392,10 +392,10 @@ vreg_l8b_e0_1p50: ldo8 {
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};
- vreg_l9b_e0_2p7: ldo9 {
- regulator-name = "vreg_l9b_e0_2p7";
- regulator-min-microvolt = <2704000>;
- regulator-max-microvolt = <2704000>;
+ vreg_l9b_e0_2p9: ldo9 {
+ regulator-name = "vreg_l9b_e0_2p9";
+ regulator-min-microvolt = <2960000>;
+ regulator-max-microvolt = <2960000>;
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH V4 2/4] dt-bindings: mmc: sdhci-msm: Document the Glymur compatible
2026-07-22 14:23 [PATCH V4 0/4] arm64: dts: qcom: Add SD card support for Glymur Monish Chunara
2026-07-22 14:23 ` [PATCH V4 1/4] arm64: dts: qcom: glymur-crd: Update VREG l2b_e0 and l9b_e0 voltage for SD-card Monish Chunara
@ 2026-07-22 14:23 ` Monish Chunara
2026-07-23 19:54 ` Rob Herring
2026-07-22 14:23 ` [PATCH V4 3/4] arm64: dts: qcom: Add SD Card support for Glymur SoC Monish Chunara
2026-07-22 14:23 ` [PATCH V4 4/4] arm64: dts: qcom: Enable SD card for Glymur CRD Monish Chunara
3 siblings, 1 reply; 6+ messages in thread
From: Monish Chunara @ 2026-07-22 14:23 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dmitry Baryshkov
Cc: Nitin Rawat, Pradeep Pragallapati, Komal Bajaj, Sachin Rathore,
Monish Chunara, linux-arm-msm, devicetree, linux-kernel
From: Monish Chunara <monish.chunara@oss.qualcomm.com>
Document the SDHCI controller on Qualcomm Glymur SoC, fully compatible
with existing MSM SDHCI v5.
Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
---
Documentation/devicetree/bindings/mmc/qcom,sdhci-msm.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mmc/qcom,sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/qcom,sdhci-msm.yaml
index b3fcc1673c10..5aa6b3a29ece 100644
--- a/Documentation/devicetree/bindings/mmc/qcom,sdhci-msm.yaml
+++ b/Documentation/devicetree/bindings/mmc/qcom,sdhci-msm.yaml
@@ -38,6 +38,7 @@ properties:
- items:
- enum:
- qcom,eliza-sdhci
+ - qcom,glymur-sdhci
- qcom,hawi-sdhci
- qcom,ipq5018-sdhci
- qcom,ipq5210-sdhci
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V4 2/4] dt-bindings: mmc: sdhci-msm: Document the Glymur compatible
2026-07-22 14:23 ` [PATCH V4 2/4] dt-bindings: mmc: sdhci-msm: Document the Glymur compatible Monish Chunara
@ 2026-07-23 19:54 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2026-07-23 19:54 UTC (permalink / raw)
To: Monish Chunara
Cc: Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski, Conor Dooley,
Dmitry Baryshkov, Nitin Rawat, Pradeep Pragallapati, Komal Bajaj,
Sachin Rathore, linux-arm-msm, devicetree, linux-kernel
On Wed, Jul 22, 2026 at 07:53:40PM +0530, Monish Chunara wrote:
> From: Monish Chunara <monish.chunara@oss.qualcomm.com>
>
> Document the SDHCI controller on Qualcomm Glymur SoC, fully compatible
> with existing MSM SDHCI v5.
>
> Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
Missing krzk's ack.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V4 3/4] arm64: dts: qcom: Add SD Card support for Glymur SoC
2026-07-22 14:23 [PATCH V4 0/4] arm64: dts: qcom: Add SD card support for Glymur Monish Chunara
2026-07-22 14:23 ` [PATCH V4 1/4] arm64: dts: qcom: glymur-crd: Update VREG l2b_e0 and l9b_e0 voltage for SD-card Monish Chunara
2026-07-22 14:23 ` [PATCH V4 2/4] dt-bindings: mmc: sdhci-msm: Document the Glymur compatible Monish Chunara
@ 2026-07-22 14:23 ` Monish Chunara
2026-07-22 14:23 ` [PATCH V4 4/4] arm64: dts: qcom: Enable SD card for Glymur CRD Monish Chunara
3 siblings, 0 replies; 6+ messages in thread
From: Monish Chunara @ 2026-07-22 14:23 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dmitry Baryshkov
Cc: Nitin Rawat, Pradeep Pragallapati, Komal Bajaj, Sachin Rathore,
Monish Chunara, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
From: Monish Chunara <monish.chunara@oss.qualcomm.com>
Add support for SD card on Glymur SoC and enable the required pinctrl
configurations.
Co-developed-by: Sachin Rathore <sachin.rathore@oss.qualcomm.com>
Signed-off-by: Sachin Rathore <sachin.rathore@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/glymur.dtsi | 91 ++++++++++++++++++++++++++++
1 file changed, 91 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
index 55d91c696a3a..e7eb710aa743 100644
--- a/arch/arm64/boot/dts/qcom/glymur.dtsi
+++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
@@ -4444,6 +4444,58 @@ lpass_ag_noc: interconnect@7e40000 {
#interconnect-cells = <2>;
};
+ sdhc_2: mmc@8804000 {
+ compatible = "qcom,glymur-sdhci", "qcom,sdhci-msm-v5";
+
+ reg = <0x0 0x08804000 0x0 0x1000>;
+ interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 223 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "hc_irq",
+ "pwr_irq";
+
+ clocks = <&gcc GCC_SDCC2_AHB_CLK>,
+ <&gcc GCC_SDCC2_APPS_CLK>,
+ <&rpmhcc RPMH_CXO_CLK>;
+ clock-names = "iface",
+ "core",
+ "xo";
+
+ iommus = <&apps_smmu 0xd00 0x0>;
+ qcom,dll-config = <0x0007442c>;
+ qcom,ddr-config = <0x80040868>;
+
+ power-domains = <&rpmhpd RPMHPD_CX>;
+ operating-points-v2 = <&sdhc2_opp_table>;
+
+ interconnects = <&aggre3_noc MASTER_SDCC_2 QCOM_ICC_TAG_ALWAYS
+ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
+ <&hsc_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
+ &config_noc SLAVE_SDCC_2 QCOM_ICC_TAG_ACTIVE_ONLY>;
+ interconnect-names = "sdhc-ddr",
+ "cpu-sdhc";
+
+ bus-width = <4>;
+ dma-coherent;
+
+ resets = <&gcc GCC_SDCC2_BCR>;
+
+ status = "disabled";
+
+ sdhc2_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-100000000 {
+ opp-hz = /bits/ 64 <100000000>;
+ required-opps = <&rpmhpd_opp_low_svs>;
+ };
+
+ opp-202000000 {
+ opp-hz = /bits/ 64 <202000000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ };
+ };
+ };
+
usb_2_hsphy: phy@88e0000 {
compatible = "qcom,glymur-m31-eusb2-phy",
"qcom,sm8750-m31-eusb2-phy";
@@ -6264,6 +6316,45 @@ rx-pins {
bias-disable;
};
};
+ sdc2_default_state: sdc2-default-state {
+ clk-pins {
+ pins = "sdc2_clk";
+ drive-strength = <16>;
+ bias-disable;
+ };
+
+ cmd-pins {
+ pins = "sdc2_cmd";
+ drive-strength = <10>;
+ bias-pull-up;
+ };
+
+ data-pins {
+ pins = "sdc2_data";
+ drive-strength = <10>;
+ bias-pull-up;
+ };
+ };
+
+ sdc2_sleep_state: sdc2-sleep-state {
+ clk-pins {
+ pins = "sdc2_clk";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ cmd-pins {
+ pins = "sdc2_cmd";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
+
+ data-pins {
+ pins = "sdc2_data";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
+ };
};
stm: stm@10002000 {
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH V4 4/4] arm64: dts: qcom: Enable SD card for Glymur CRD
2026-07-22 14:23 [PATCH V4 0/4] arm64: dts: qcom: Add SD card support for Glymur Monish Chunara
` (2 preceding siblings ...)
2026-07-22 14:23 ` [PATCH V4 3/4] arm64: dts: qcom: Add SD Card support for Glymur SoC Monish Chunara
@ 2026-07-22 14:23 ` Monish Chunara
3 siblings, 0 replies; 6+ messages in thread
From: Monish Chunara @ 2026-07-22 14:23 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dmitry Baryshkov
Cc: Nitin Rawat, Pradeep Pragallapati, Komal Bajaj, Sachin Rathore,
Monish Chunara, linux-arm-msm, devicetree, linux-kernel
From: Monish Chunara <monish.chunara@oss.qualcomm.com>
Enable SD card for Glymur CRD platform. Configure the vmmc/vqmmc
regulators and gpio-based card detection for the platform.
Co-developed-by: Sachin Rathore <sachin.rathore@oss.qualcomm.com>
Signed-off-by: Sachin Rathore <sachin.rathore@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/glymur-crd.dtsi | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
index 2e41b4ec83a5..9251019fd31f 100644
--- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
+++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
@@ -905,6 +905,22 @@ &smb2370_k_e2_eusb2_repeater {
vdd3-supply = <&vreg_l7b_e0_2p79>;
};
+&sdhc_2 {
+ vmmc-supply = <&vreg_l9b_e0_2p9>;
+ vqmmc-supply = <&vreg_l2b_e0_2p9>;
+
+ pinctrl-0 = <&sdc2_default_state &sdc2_card_det_n>;
+ pinctrl-1 = <&sdc2_sleep_state &sdc2_card_det_n>;
+ pinctrl-names = "default", "sleep";
+
+ cd-gpios = <&tlmm 221 GPIO_ACTIVE_LOW>;
+
+ no-mmc;
+ no-sdio;
+
+ status = "okay";
+};
+
&swr0 {
status = "okay";
@@ -1090,6 +1106,13 @@ wake-n-pins {
};
};
+ sdc2_card_det_n: sd-card-det-n-state {
+ pins = "gpio221";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
tpad_default: tpad-default-state {
pins = "gpio3";
function = "gpio";
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread