From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: bp@alien8.de, tony.luck@intel.com, rounakdas2025@gmail.com,
niravkumar.l.rabara@altera.com, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/4] EDAC/altera: use flag to differentiate 64-bit platforms
Date: Fri, 24 Jul 2026 11:41:09 +0200 [thread overview]
Message-ID: <20260724-spotted-resilient-badger-495b71@quoll> (raw)
In-Reply-To: <20260720201425.1538771-3-dinguyen@kernel.org>
On Mon, Jul 20, 2026 at 03:14:23PM -0500, Dinh Nguyen wrote:
> MODULE_DEVICE_TABLE(of, altr_edac_a10_of_match);
> diff --git a/drivers/edac/altera_edac.h b/drivers/edac/altera_edac.h
> index 9387056fd65e3..74ab7bfc3e748 100644
> --- a/drivers/edac/altera_edac.h
> +++ b/drivers/edac/altera_edac.h
> @@ -351,6 +351,9 @@ struct altr_sdram_mc_data {
> #define ECC_READ_EOVR 0x2
> #define ECC_READ_EDOVR 0x3
>
> +#define SOCFPGA_S10 0x1
> +#define SOCFPGA_AGILEX5 0x2
You want an enum, not defines.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-24 9:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 20:14 [PATCH 0/4] EDAC/altera: Add support for Agilex5 platform Dinh Nguyen
2026-07-20 20:14 ` [PATCH 1/4] dt-bindings: edac: altera: agilex5: document new edac support Dinh Nguyen
2026-07-20 20:21 ` sashiko-bot
2026-07-24 9:39 ` Krzysztof Kozlowski
2026-07-29 20:43 ` [PATCH 1/2] dt-bindings: altera-sdram: Add Agilex5 ECC manager compatible Rounak Das
2026-07-30 5:56 ` Krzysztof Kozlowski
2026-07-30 9:04 ` Krzysztof Kozlowski
2026-07-30 16:32 ` Rounak Das
2026-07-20 20:14 ` [PATCH 2/4] EDAC/altera: use flag to differentiate 64-bit platforms Dinh Nguyen
2026-07-20 20:30 ` sashiko-bot
2026-07-24 9:41 ` Krzysztof Kozlowski [this message]
2026-07-29 20:46 ` [PATCH 2/2] EDAC/altera: Use an enum to identify the platform variant Rounak Das
2026-07-20 20:14 ` [PATCH 3/4] EDAC/altera: Add support for Agilex5 ECC manager Dinh Nguyen
2026-07-20 20:25 ` sashiko-bot
2026-07-20 20:14 ` [PATCH 4/4] arm64: dts: socfpga: agilex5: add support for the " Dinh Nguyen
2026-07-20 20:35 ` sashiko-bot
2026-07-24 9:43 ` Krzysztof Kozlowski
2026-07-20 20:33 ` [PATCH 0/4] EDAC/altera: Add support for Agilex5 platform Borislav Petkov
2026-07-30 17:38 ` Rounak Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260724-spotted-resilient-badger-495b71@quoll \
--to=krzk@kernel.org \
--cc=bp@alien8.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niravkumar.l.rabara@altera.com \
--cc=robh@kernel.org \
--cc=rounakdas2025@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox