From: sashiko-bot@kernel.org
To: "Pavan Kumar" <pavan.m@oss.qualcomm.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v6] arm64: dts: qcom: qcm6490-idp: Add IPA node
Date: Fri, 24 Jul 2026 05:23:00 +0000 [thread overview]
Message-ID: <20260724052300.9A77A1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260724050846.3413161-1-pavan.m@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing `memory-region` and `qcom,gsi-loader` properties in the `&ipa` node will cause the IPA driver probe to fail.
--
--- Patch [1]: [PATCH v6] arm64: dts: qcom: qcm6490-idp: Add IPA node ---
commit acbf8a7703458aa79f155d2680e69e464cb8f6f4
Author: Pavan Kumar <pavan.m@oss.qualcomm.com>
arm64: dts: qcom: qcm6490-idp: Add IPA node
This commit enables the IPA block and provides the firmware name required for
firmware loading on the qcm6490-idp board.
Link: https://lore.kernel.org/all/20260722082314.1502072-1-pavan.m@oss.qualcomm.com/
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index bdc02260f902b..7242695aed978 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
[ ... ]
> @@ -619,6 +619,12 @@ &gpu_zap_shader {
> firmware-name = "qcom/qcm6490/a660_zap.mbn";
> };
>
> +&ipa {
> + firmware-name = "qcom/qcm6490/ipa_fws.mbn";
> +
> + status = "okay";
> +};
[Severity: High]
Will this configuration cause the IPA driver probe to fail?
During device initialization, the IPA driver in drivers/net/ipa/ipa_main.c
checks for the qcom,gsi-loader property. Without it, the driver falls back
to IPA_LOADER_SELF.
The ipa_probe() function then calls ipa_firmware_load(), which requires the
memory-region property to map the firmware memory via
of_reserved_mem_region_to_resource().
Since the memory-region property appears to be missing from both this &ipa
override and the base kodiak.dtsi, will this lookup return -ENODEV and abort
the driver probe?
Should the memory-region and qcom,gsi-loader properties be included in this
node to ensure successful initialization?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260724050846.3413161-1-pavan.m@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-07-24 5:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 5:08 [PATCH v6] arm64: dts: qcom: qcm6490-idp: Add IPA node Pavan Kumar
2026-07-24 5:23 ` sashiko-bot [this message]
2026-07-24 8:19 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260724052300.9A77A1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=pavan.m@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox