[PATCH v6] arm64: dts: qcom: qcm6490-idp: Add IPA node

[PATCH v6] arm64: dts: qcom: qcm6490-idp: Add IPA node

[Pavan Kumar]

Enable the IPA block and provide the firmware name
required for firmware loading on qcm6490-idp.

Signed-off-by: Pavan Kumar <pavan.m@oss.qualcomm.com>
---
Changes in v6:
- Corrected the board name in the commit subject from qcom6490-idp to qcm6490-idp.
Changes in v5:
- Reworked commit message to describe the functionality being enabled.
- Removed IPA property consolidation explanation.
- Removed obsolete Link tag to IPA loader series.
- Clarified that the change applies to qcm6490-idp.
Changes in v4:
- Removed empty line between Link and Signed-off-by tags.
- Added empty line before the status property in the IPA node.
- Sent as a new thread instead of replying to the previous revision.
Changes in v3:
- Rebased on top of IPA property consolidation series.
- Dropped qcom,gsi-loader and memory-region properties as they are now
  provided by kodiak.dtsi.
- Added Link tag to the dependent IPA loader series.
Changes in v2:
- Modified firmware file extension from .mdt to .mbn

v5: https://lore.kernel.org/all/20260722082314.1502072-1-pavan.m@oss.qualcomm.com/
v4: https://lore.kernel.org/all/20260703085809.2573214-1-sarat.addepalli@oss.qualcomm.com/
v3: https://lore.kernel.org/all/20260702105509.1360340-1-sarat.addepalli@oss.qualcomm.com/
v2: https://lore.kernel.org/all/20260618124700.2001191-1-sarat.addepalli@oss.qualcomm.com/
v1: https://lore.kernel.org/all/20250304152133.GA2763820@hu-kapandey-hyd.qualcomm.com/
---
 arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
index bdc02260f902..7242695aed97 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
@@ -619,6 +619,12 @@ &gpu_zap_shader {
 	firmware-name = "qcom/qcm6490/a660_zap.mbn";
 };
 
+&ipa {
+	firmware-name = "qcom/qcm6490/ipa_fws.mbn";
+
+	status = "okay";
+};
+
 &lpass_rx_macro {
 	status = "okay";
 };

Re: [PATCH v6] arm64: dts: qcom: qcm6490-idp: Add IPA node

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing `memory-region` and `qcom,gsi-loader` properties in the `&ipa` node will cause the IPA driver probe to fail.
--

--- Patch [1]: [PATCH v6] arm64: dts: qcom: qcm6490-idp: Add IPA node ---
commit acbf8a7703458aa79f155d2680e69e464cb8f6f4
Author: Pavan Kumar <pavan.m@oss.qualcomm.com>

arm64: dts: qcom: qcm6490-idp: Add IPA node

This commit enables the IPA block and provides the firmware name required for
firmware loading on the qcm6490-idp board.

Link: https://lore.kernel.org/all/20260722082314.1502072-1-pavan.m@oss.qualcomm.com/

> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index bdc02260f902b..7242695aed978 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
[ ... ]
> @@ -619,6 +619,12 @@ &gpu_zap_shader {
>  	firmware-name = "qcom/qcm6490/a660_zap.mbn";
>  };
>  
> +&ipa {
> +	firmware-name = "qcom/qcm6490/ipa_fws.mbn";
> +
> +	status = "okay";
> +};

[Severity: High]
Will this configuration cause the IPA driver probe to fail?

During device initialization, the IPA driver in drivers/net/ipa/ipa_main.c
checks for the qcom,gsi-loader property. Without it, the driver falls back
to IPA_LOADER_SELF.

The ipa_probe() function then calls ipa_firmware_load(), which requires the
memory-region property to map the firmware memory via
of_reserved_mem_region_to_resource().

Since the memory-region property appears to be missing from both this &ipa
override and the base kodiak.dtsi, will this lookup return -ENODEV and abort
the driver probe?

Should the memory-region and qcom,gsi-loader properties be included in this
node to ensure successful initialization?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724050846.3413161-1-pavan.m@oss.qualcomm.com?part=1