Re: [PATCH v13 1/5] dt-bindings: pwm: dwc: Document optional resets property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The timer binding for the same hardware family (`timer/snps,dw-apb-timer.yaml`) was not updated to reflect the newly documented reset lines.
--

--- Patch [1]: [PATCH v13 1/5] dt-bindings: pwm: dwc: Document optional resets property ---
commit 1c2d313919493838e6334a2a8bbd90732e217da2
Author: Xuyang Dong <dongxuyang@eswincomputing.com>

dt-bindings: pwm: dwc: Document optional resets property

This commit adds the resets and reset-names properties to the DesignWare PWM
IP binding. It documents the active-low presetn and timer_N_resetn inputs for
the bus and timer domains respectively.

> diff --git a/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml b/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml
> index 7523a89a17733..1f9d72f9f3590 100644
> --- a/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml
> +++ b/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml
> @@ -43,6 +43,16 @@ properties:
>        - const: bus
>        - const: timer
>  
> +  resets:
> +    items:
> +      - description: Interface bus (presetn) reset
> +      - description: PWM timer logic (timer_N_resetn) reset
> +
> +  reset-names:
> +    items:
> +      - const: bus
> +      - const: timer

[Severity: Medium]
Should the standard timer binding for this exact same hardware module also
be updated to reflect these two newly documented reset lines?

The timer binding for the same hardware family currently only specifies
a single reset:

Documentation/devicetree/bindings/timer/snps,dw-apb-timer.yaml:
  resets:
    maxItems: 1

If a device tree author adds the second reset line to a timer node
representing this IP, will it incorrectly fail schema validation against
snps,dw-apb-timer.yaml since that file lacks reset-names and caps maxItems
at 1?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724084153.1473-1-dongxuyang@eswincomputing.com?part=1