Re: [PATCH v2 3/6] iio: dac: ad5686: refactor device list and file header comments

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete implementation of device removal: AD5337R is left in ID tables despite commit message claim.
--

--- Patch [3]: [PATCH v2 3/6] iio: dac: ad5686: refactor device list and file header comments ---
commit f78bcff1ca70cede516f95f60a18e8d26ad243b8
Author: Rodrigo Alencar <rodrigo.alencar@analog.com>

iio: dac: ad5686: refactor device list and file header comments

This commit refactors the Kconfig device list by sorting devices by channel
count and removes device descriptions from the file headers. It also states
in the commit message that AD5337R is being omitted.

> AD5337R is ommited as it does not seem to exist, i.e. its documentation could not be found.

[Severity: Medium]
Is the removal of AD5337R incomplete in this patch?

The commit message notes that AD5337R is omitted, and it was removed from
the Kconfig text, but the driver still registers the device.

For example, it remains in the i2c_device_id table:

drivers/iio/dac/ad5696-i2c.c:ad5686_i2c_id[] = {
    ...
    { .name = "ad5337r", .driver_data = (kernel_ulong_t)&ad5337r_chip_info },
    ...
}

It also remains in the of_device_id table in the same file:

drivers/iio/dac/ad5696-i2c.c:ad5686_of_match[] = {
    ...
    { .compatible = "adi,ad5337r", .data = &ad5337r_chip_info },
    ...
}

The core driver also still exports its chip info structure:

drivers/iio/dac/ad5686.c:
const struct ad5686_chip_info ad5337r_chip_info = {
    .channels = ad5337r_channels,
    .int_vref_mv = 2500,
    .num_channels = 2,
    .regmap_type = AD5686_REGMAP,
};
EXPORT_SYMBOL_NS_GPL(ad5337r_chip_info, "IIO_AD5686");

Should these entries be removed as well to fully drop the device support?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724-ad5686-extend-dev-support-v2-0-cfc2b30ce988@analog.com?part=3