From: sashiko-bot@kernel.org
To: "Rodrigo Alencar" <rodrigo.alencar@analog.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: iio: dac: ad5696: add AD5673R/AD5677R support
Date: Fri, 24 Jul 2026 12:18:55 +0000 [thread overview]
Message-ID: <20260724121855.CE1DF1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260724-ad5686-extend-dev-support-v2-1-cfc2b30ce988@analog.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Missing 'adi,ad5673r' and 'adi,ad5677r' in the ad5696-i2c driver's of_device_id table breaks module autoloading.
--
--- Patch [1]: [PATCH v2 1/6] dt-bindings: iio: dac: ad5696: add AD5673R/AD5677R support ---
commit 0615f695e24a3ce3cbdf232377b1a0e2894200a2
Author: Rodrigo Alencar <rodrigo.alencar@analog.com>
dt-bindings: iio: dac: ad5696: add AD5673R/AD5677R support
Add compatible entries for the AD5673R and AD5677R devices to the ad5696
device tree bindings. These 16-channel devices use different bit resolutions
so no fallback compatibles are used.
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> index e10f8596f9d3f..5a93edc976f01 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> @@ -19,7 +19,9 @@ properties:
> - adi,ad5337r
> - adi,ad5338r
> - adi,ad5671r
> + - adi,ad5673r
> - adi,ad5675r
> + - adi,ad5677r
[Severity: High]
This isn't a bug introduced by this patch, but does the driver also need
to be updated to match these new compatible strings?
Looking at drivers/iio/dac/ad5696-i2c.c:ad5686_of_match():
static const struct of_device_id ad5686_of_match[] = {
{ .compatible = "adi,ad5311r", .data = &ad5311r_chip_info },
...
It appears 'adi,ad5673r' and 'adi,ad5677r' are missing from this table.
When the system boots and the I2C core generates an of: modalias for
DT-instantiated devices, could the lack of these entries cause module
autoloading to silently fail for the ad5696-i2c driver?
> - adi,ad5691r
> - adi,ad5692r
> - adi,ad5693
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260724-ad5686-extend-dev-support-v2-0-cfc2b30ce988@analog.com?part=1
next prev parent reply other threads:[~2026-07-24 12:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 12:03 [PATCH v2 0/6] iio: dac: ad5686: extend device support Rodrigo Alencar via B4 Relay
2026-07-24 12:03 ` [PATCH v2 1/6] dt-bindings: iio: dac: ad5696: add AD5673R/AD5677R support Rodrigo Alencar via B4 Relay
2026-07-24 12:18 ` sashiko-bot [this message]
2026-07-24 16:53 ` Conor Dooley
2026-07-24 12:03 ` [PATCH v2 2/6] iio: dac: ad5696: add AD5673R/AD5677R entries to of_match table Rodrigo Alencar via B4 Relay
2026-07-24 12:03 ` [PATCH v2 3/6] iio: dac: ad5686: refactor device list and file header comments Rodrigo Alencar via B4 Relay
2026-07-24 12:16 ` sashiko-bot
2026-07-24 12:03 ` [PATCH v2 4/6] dt-bindings: iio: dac: ad5696: extend device support Rodrigo Alencar via B4 Relay
2026-07-24 12:17 ` sashiko-bot
2026-07-24 16:53 ` Conor Dooley
2026-07-24 12:03 ` [PATCH v2 5/6] dt-bindings: iio: dac: ad5686: " Rodrigo Alencar via B4 Relay
2026-07-24 12:03 ` [PATCH v2 6/6] iio: dac: ad5686: extend device support with new parts Rodrigo Alencar via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260724121855.CE1DF1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rodrigo.alencar@analog.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox