Re: [PATCH v3 2/9] dt-bindings: interrupt-controller: apple,aic2: Invert #interrupt-cells condition

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The newly inverted conditional block fails to include the M3 generation multi-die SoCs (e.g., `apple,t6031-aic3`), incorrectly restricting them to 3 interrupt cells and defeating the purpose of the patch.
- [Medium] The compatible string `apple,t6031-aic3` explicitly mentioned in the commit message is missing from the top-level schema definition.
--

--- Patch [2]: [PATCH v3 2/9] dt-bindings: interrupt-controller: apple,aic2: Invert #interrupt-cells condition ---
commit fc6ebf906f40d7b153e442ba25ef2691b2d4b00f
Author: Janne Grunau <j@jannau.net>

dt-bindings: interrupt-controller: apple,aic2: Invert #interrupt-cells condition

This commit changes the conditional logic for #interrupt-cells in the Apple
AIC2 binding. It aims to explicitly list multi-die SoC compatibles that
require 4 cells instead of defaulting to 4.

> The condition for 3 or 4 #interrupt-cells list compatibles for the 3
> cells variant (not used in SoCs consisting out of multiple dies). This
> includes the AICv3 base compatible "apple,t8122-aic3". This will match
>     compatible = "apple,t6031-aic3", "apple,t8122-aic3";
> shared for M3 Max and Ultra based devices which require the additional
> interrupt cell for the die number.

[Severity: Medium]
Should apple,t6031-aic3 be added to the top-level properties:compatible array?

Any device tree using the apple,t6031-aic3 compatible string will fail
dt_binding_check validation because it is entirely undocumented in the schema.

> diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> index d0d9a90e96e7b..a94787939d345 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> @@ -128,16 +128,16 @@ allOf:
>          compatible:
>            contains:
>              enum:
> -              - apple,t8112-aic
> -              - apple,t8122-aic3
> +              - apple,t6000-aic
> +              - apple,t6020-aic

[Severity: Medium]
Does this enum explicitly list all multi-die SoCs that require 4 cells?

The commit message mentions that the 4-cell requirement applies to 
apple,t6031-aic3, but since it is missing from this newly added enum, 
the schema logic will fall into the else branch and apply the const: 3 
constraint. 

Will this incorrectly restrict M3 Max/Ultra multi-die SoCs to 3 interrupt
cells, causing valid device trees to fail schema validation?

>      then:
>        properties:
>          '#interrupt-cells':
> -          const: 3
> +          const: 4
>      else:
>        properties:
>          '#interrupt-cells':
> -          const: 4
> +          const: 3

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724-apple-t603x-initial-devices-v3-0-bbeba0420603@jannau.net?part=2