Re: [PATCH v3 4/9] dt-bindings: arm: apple: apple,pmgr: Add t6030 and t6031 compatibles

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete device tree binding updates for Apple PMGR subnodes.
--

--- Patch [4]: [PATCH v3 4/9] dt-bindings: arm: apple: apple,pmgr: Add t6030 and t6031 compatibles ---
commit bc25eb1e6eaf03811fe921a56f06dda28c171040
Author: Janne Grunau <j@jannau.net>
dt-bindings: arm: apple: apple,pmgr: Add t6030 and t6031 compatibles

This commit adds per-SoC compatible strings for the Apple M3 Pro, Max,
and Ultra PMGR blocks to the apple,pmgr.yaml binding.

> diff --git a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
> index c67b67ba065af..1d2001836eb48 100644
> --- a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
> +++ b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
> @@ -38,6 +38,8 @@ properties:
>        - items:
>            - enum:
>                - apple,t6020-pmgr
> +              - apple,t6030-pmgr
> +              - apple,t6031-pmgr

[Severity: Medium]
Should the corresponding power state compatibles (apple,t6030-pmgr-pwrstate
and apple,t6031-pmgr-pwrstate) also be added to the child subnodes?

Because apple,t6030-pmgr and apple,t6031-pmgr are added to the parent
apple,pmgr.yaml here, device trees implementing the new M3 SoCs will fail
schema validation when defining power-controller subnodes using per-SoC
compatible strings.

For context, earlier generations are enumerated in the power state binding
under properties:compatible like this:

Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml:
      - items:
          - enum:
              - apple,t6020-pmgr-pwrstate
              - apple,t8122-pmgr-pwrstate
          - const: apple,t8103-pmgr-pwrstate

Does this regression mean make dtbs_check will fail for device trees using
these new M3 variants?

>                - apple,t8122-pmgr
>            - const: apple,t8103-pmgr
>            - const: syscon

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724-apple-t603x-initial-devices-v3-0-bbeba0420603@jannau.net?part=4