Re: [PATCH v5 1/6] dt-bindings: display: panel: Modify reset gpio number constrain

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The patch relaxes the `reset-gpios` constraint in `panel-common.yaml` to allow multiple GPIOs, but fails to update the global `gpio-consumer-common.yaml` schema, which strictly enforces a maximum of 1 item.
- [Medium] Replacing `maxItems: 1` with `minItems: 1` entirely removes the upper bound from the `reset-gpios` property, violating the dt-schema meta-schema requirements for phandle arrays.
--

--- Patch [1]: [PATCH v5 1/6] dt-bindings: display: panel: Modify reset gpio number constrain ---
commit bef64e9dd2f24e3eff4806992787382fb7261e4b
Author: Jun Nie <jun.nie@linaro.org>

dt-bindings: display: panel: Modify reset gpio number constrain

This patch modifies the constraints for reset-gpios in the display panel
bindings to support panels that require two reset lines, such as the
Synaptics R63455. It replaces the maximum item constraint with a minimum
item constraint.

> diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> --- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
[ ... ]
>    reset-gpios:
> -    maxItems: 1
> +    minItems: 1

[Severity: Medium]
Does removing the maxItems constraint violate the dt-schema meta-schema rules?
Array properties ending in -gpios generally require maxItems or items to be
defined to provide a strict upper bound. Leaving this unbounded could cause
the binding to trigger errors when validated against the core meta-schema.

[Severity: Medium]
Even with this local change, won't panels specifying two reset gpios still
fail schema validation due to the global gpio schema?

The global schema restricts reset-gpios:

Documentation/devicetree/bindings/gpio/gpio-consumer-common.yaml:allOf()
    else:
      properties:
        reset-gpios:
          maxItems: 1

This implicitly overrides the relaxed constraint in the panel schema. Does
gpio-consumer-common.yaml also need an update to allow for multiple
reset-gpios in panel nodes?

>      description:
>        Specifier for a GPIO connected to the panel reset control signal.
>        The reset signal is active low and resets the panel internal logic

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-sm8650-7-1-bonded-dsi-v5-0-c042266b9eeb@linaro.org?part=1