Re: [PATCH v9 1/2] dt-bindings: media: i2c: Add mira220 image sensor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing `minItems: 1` in `data-lanes` unintentionally drops 1-lane support.
--

--- Patch [1]: [PATCH v9 1/2] dt-bindings: media: i2c: Add mira220 image sensor ---
commit a07e0c84ef20042ffd0f045f21d59c669b882854
Author: Philippe Baetens <philippebaetens@gmail.com>

dt-bindings: media: i2c: Add mira220 image sensor

This commit adds device tree bindings for the AMSOSRAM Mira220 image sensor.

> diff --git a/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml b/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml
> new file mode 100644
> index 0000000000000..fa6fec0072efa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml

[ ... ]

> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          data-lanes:
> +            items:
> +              - const: 1
> +              - const: 2

[Severity: Medium]
By defining items as a tuple array without an explicit minItems value, will
dt-schema automatically infer and enforce minItems: 2?

The changelog mentions removing the anyOf block from data-lanes in v5.
Without minItems: 1, does this inadvertently make valid device trees using
a 1-lane configuration fail schema validation?

If 1-lane setups are still supported by the hardware, should minItems: 1
be included here?

> +
> +        required:
> +          - data-lanes
> +          - link-frequencies

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-mira220-v9-0-e869e7ec2040@ideasonboard.com?part=1