Re: [PATCH v9 2/2] media: i2c: Add driver for AMS-OSRAM Mira220

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Unused `fmt` field in `struct mira220`.
--

--- Patch [2]: [PATCH v9 2/2] media: i2c: Add driver for AMS-OSRAM Mira220 ---
commit 1a645456404fc78085c443f892a4b50ad94cb5ab
Author: Philippe Baetens <philippebaetens@gmail.com>
Subject: media: i2c: Add driver for AMS-OSRAM Mira220

This commit adds a V4L2 subdev driver for the AMS-OSRAM Mira220 image sensor.
The sensor is a global shutter imager supporting monochrome and RGB formats.
It implements MIPI CSI-2 output with data rates up to 1500Mbit/s per lane.

> diff --git a/drivers/media/i2c/mira220.c b/drivers/media/i2c/mira220.c
> new file mode 100644
> index 0000000000000..f977bc5988261
> --- /dev/null
> +++ b/drivers/media/i2c/mira220.c
[ ... ]
> +struct mira220 {
> +	struct v4l2_subdev sd;
> +	struct media_pad pad;
> +
> +	enum mira220_variants variant;
> +
> +	struct v4l2_mbus_framefmt fmt;

[Severity: Medium]
The commit log mentions "remove format from driver structure" under the v4->v5
changes, but it appears fmt is still present in struct mira220 and unused
throughout the driver. Is this a leftover that can be removed?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-mira220-v9-0-e869e7ec2040@ideasonboard.com?part=2