Re: [PATCH v8 1/4] dt-bindings: leds: nxp,pca963x: fix reg maximum for pca9635

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The `patternProperties` regex key in `allOf` conditionals does not match the top-level schema, causing a meta-schema validation (`dt_binding_check`) error.
- [Low] The commit message description is not capitalized, violating the LED subsystem guidelines.
--

--- Patch [1]: [PATCH v8 1/4] dt-bindings: leds: nxp,pca963x: fix reg maximum for pca9635 ---
commit febe95d1e68d24e8ea2c7f7724fbc41453e15f8d
Author: Loic Poulain <loic.poulain@oss.qualcomm.com>

dt-bindings: leds: nxp,pca963x: fix reg maximum for pca9635

This commit updates the PCA963x LED bindings to support the PCA9635, which
has 16 channels. It modifies the top-level node regex and adjusts the 
conditional blocks to set the appropriate reg maximum for the PCA9634.

> dt-bindings: leds: nxp,pca963x: fix reg maximum for pca9635

[Severity: Low]
This isn't a bug, but the LED subsystem guidelines require capitalizing the 
description after the subsystem prefix. Should this be "Fix reg maximum..."?

> diff --git a/Documentation/devicetree/bindings/leds/nxp,pca963x.yaml b/Documentation/devicetree/bindings/leds/nxp,pca963x.yaml
> index 938d0e48fe51b..4fda602912f7a 100644
> --- a/Documentation/devicetree/bindings/leds/nxp,pca963x.yaml
> +++ b/Documentation/devicetree/bindings/leds/nxp,pca963x.yaml

[ ... ]

> @@ -62,14 +62,14 @@ properties:
>        open-drain, newer chips to totem pole).
>  
>  patternProperties:
> -  "^led@[0-9a-f]+$":
> +  "^led@[0-9a-f]$":
>      type: object

[ ... ]

> @@ -88,7 +88,13 @@ allOf:
>            properties:
>              reg:
>                maximum: 3
> -    else:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - nxp,pca9634
> +    then:
>        patternProperties:
>          "^led@[0-9a-f]+$":

[Severity: Low]
Does this regex in the conditional block need to be updated to match the new
top-level regex "^led@[0-9a-f]$"? 

In dt-schema, pattern keys inside conditional blocks must exactly match a key 
defined at the top-level patternProperties, or dt_binding_check will fail. 

There is also an earlier conditional block for pca9632/pca9633 that appears to
retain the old "^led@[0-9a-f]+$" regex. Should both of these conditionals be 
updated to prevent meta-schema validation errors?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-monza-leds-v8-0-6e7e93d44dba@oss.qualcomm.com?part=1