From: sashiko-bot@kernel.org
To: "Loic Poulain" <loic.poulain@oss.qualcomm.com>
Cc: robh@kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, lee@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v8 2/4] dt-bindings: leds: nxp,pca963x: add multicolor LED support
Date: Mon, 27 Jul 2026 15:01:57 +0000 [thread overview]
Message-ID: <20260727150157.A42731F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260727-monza-leds-v8-2-6e7e93d44dba@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message description is not capitalized, violating the LED subsystem guidelines.
--
--- Patch [2]: [PATCH v8 2/4] dt-bindings: leds: nxp,pca963x: add multicolor LED support ---
commit 8880deb882c1836deb8075651311f02e71683b95
Author: Loic Poulain <loic.poulain@oss.qualcomm.com>
dt-bindings: leds: nxp,pca963x: add multicolor LED support
This commit adds support for grouping individual PCA963x channels into a
multicolor LED by introducing a multi-led node pattern. This is necessary
to support and model hardware setups where multiple PWM channels drive a
single physical RGB LED.
> dt-bindings: leds: nxp,pca963x: add multicolor LED support
[Severity: Low]
This isn't a bug, but the description after the subsystem prefix is not
capitalized ("add" instead of "Add").
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-monza-leds-v8-0-6e7e93d44dba@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-07-27 15:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 14:54 [PATCH v8 0/4] leds: pca963x: Add multicolor support and enable Monza RGB LEDs Loic Poulain
2026-07-27 14:54 ` [PATCH v8 1/4] dt-bindings: leds: nxp,pca963x: fix reg maximum for pca9635 Loic Poulain
2026-07-27 15:01 ` sashiko-bot
2026-07-27 14:54 ` [PATCH v8 2/4] dt-bindings: leds: nxp,pca963x: add multicolor LED support Loic Poulain
2026-07-27 15:01 ` sashiko-bot [this message]
2026-07-27 14:54 ` [PATCH v8 3/4] leds: pca963x: add multicolor LED class support Loic Poulain
2026-07-27 15:11 ` sashiko-bot
2026-07-27 14:54 ` [PATCH v8 4/4] arm64: dts: monaco-arduino-monza: microcontroller LEDs Loic Poulain
2026-07-27 14:58 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727150157.A42731F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox