[PATCH] ARM: dts: BCM5301X: panamera: add phy-mode to switch

[PATCH] ARM: dts: BCM5301X: panamera: add phy-mode to switch

[Rosen Penev]

phy-mode is needed for CPU ports based on the documentation.

Fixes dtbs_checks warning:

switch@0 (brcm,bcm53125): ports:port@8: 'phy-mode' is a required property
from schema $id: http://devicetree.org/schemas/net/dsa/brcm,b53.yaml

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 arch/arm/boot/dts/broadcom/bcm47094-linksys-panamera.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/broadcom/bcm47094-linksys-panamera.dts b/arch/arm/boot/dts/broadcom/bcm47094-linksys-panamera.dts
index e02a7a902f72..372601f0d56d 100644
--- a/arch/arm/boot/dts/broadcom/bcm47094-linksys-panamera.dts
+++ b/arch/arm/boot/dts/broadcom/bcm47094-linksys-panamera.dts
@@ -183,6 +183,7 @@ port@4 {
 					sw1_p8: port@8 {
 						reg = <8>;
 						ethernet = <&sw0_p0>;
+						phy-mode = "internal";
 						label = "cpu";
 
 						fixed-link {
-- 
2.55.0

Re: [PATCH] ARM: dts: BCM5301X: panamera: add phy-mode to switch

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect physical interface mode for external switch CPU port
--

--- Patch [1]: [PATCH] ARM: dts: BCM5301X: panamera: add phy-mode to switch ---
commit 2598ed8af439b245eb41bd31bdc3a006d830e5ec
Author: Rosen Penev <rosenp@gmail.com>

ARM: dts: BCM5301X: panamera: add phy-mode to switch

This commit adds the phy-mode property to the CPU port of the BCM53125 switch
to resolve a device tree schema validation warning.

> diff --git a/arch/arm/boot/dts/broadcom/bcm47094-linksys-panamera.dts b/arch/arm/boot/dts/broadcom/bcm47094-linksys-panamera.dts
> index 74161b76008ad..bc497d59ea805 100644
> --- a/arch/arm/boot/dts/broadcom/bcm47094-linksys-panamera.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm47094-linksys-panamera.dts
> @@ -184,6 +184,7 @@ port@4 {
>  					sw1_p8: port@8 {
>  						reg = <8>;
>  						ethernet = <&sw0_p0>;
> +						phy-mode = "internal";

[Severity: Medium]
Is "internal" the correct physical interface mode for this external switch CPU
port?

The b53 DSA driver evaluates phy_interface_mode_is_rgmii() to configure RGMII
delays via b53_adjust_531x5_rgmii(). Setting the mode to "internal" bypasses
this logic for what appears to be an external MAC-to-MAC connection.

Does this codify an incorrect hardware description that prevents the kernel from
managing the connection timing correctly?

>  						label = "cpu";
>  
>  						fixed-link {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727225954.268155-1-rosenp@gmail.com?part=1