Re: [PATCH 3/4] arm64: dts: qcom: sm8550-hdk: Enable I2S for HDMI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added `dai@16` node violates both the Device Tree Specification for unit-address formatting and the `qcom,q6apm-lpass-dais.yaml` schema for the `clock-names` array order.
--

--- Patch [3]: [PATCH 3/4] arm64: dts: qcom: sm8550-hdk: Enable I2S for HDMI ---
commit 2cee2013f7677aa1232b3d7385d6857db3191e25
Author: Neil Armstrong <neil.armstrong@linaro.org>

arm64: dts: qcom: sm8550-hdk: Enable I2S for HDMI

Add the necessary nodes to configure the right I2S interface
to output audio via the DSI HDMI bridge.

> diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> index ee13e6136a825..87792fbf3323f 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts

[ ... ]

> @@ -1144,6 +1165,19 @@ pmk8550_sleep_clk: sleep-clk-state {
>  	};
>  };
>  
> +&q6apmbedai {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	dai@16 {
> +		reg = <PRIMARY_MI2S_RX>;
> +		clocks = <&q6prmcc LPASS_CLK_ID_MCLK_1 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> +			 <&q6prmcc LPASS_CLK_ID_PRI_MI2S_IBIT LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
> +		clock-names = "mclk",
> +			      "bclk";

[Severity: Low]
Should this unit address be formatted as hex (dai@10) instead of decimal to
avoid dtc unit_address_vs_reg warnings, since PRIMARY_MI2S_RX is 16 (0x10)?

Also, does the clock-names array order match the qcom,q6apm-lpass-dais.yaml
schema expectations? It appears the schema expects mclk as the second item,
rather than the first, which might trigger a validation failure during
make dtbs_check.

> +	};
> +};
> +
>  &qupv3_id_0 {
>  	status = "okay";
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260728-topic-sm8x50-next-hdk-i2s-v1-0-2393a0fe4aa9@linaro.org?part=3