Re: [PATCH 4/4] arm64: dts: qcom: sm8650-hdk: Enable I2S for HDMI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Devicetree unit address mismatch in the newly added `dai@16` node.
--

--- Patch [4]: [PATCH 4/4] arm64: dts: qcom: sm8650-hdk: Enable I2S for HDMI ---
commit 26369b0d894fd5b99316fa96e29c974138026f04
Author: Neil Armstrong <neil.armstrong@linaro.org>

arm64: dts: qcom: sm8650-hdk: Enable I2S for HDMI

This commit adds the necessary nodes to configure the I2S interface
for outputting audio via the DSI HDMI bridge.

> diff --git a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts
> index eabc828c05b4c..69327c4857e1f 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts

[ ... ]

> @@ -1072,6 +1092,19 @@ &pon_resin {
>  	status = "okay";
>  };
>  
> +&q6apmbedai {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	dai@16 {
> +		reg = <PRIMARY_MI2S_RX>;

[Severity: Low]
Should the unit address match the hex value of the reg property?
PRIMARY_MI2S_RX resolves to 16 in decimal, which is 0x10 in hex. Since
devicetree unit addresses are required to be formatted as lowercase
hexadecimal without a leading 0x, shouldn't this node be named dai@10
to avoid a unit_address_mismatch compilation warning?

> +		clocks = <&q6prmcc LPASS_CLK_ID_MCLK_1 LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> +			 <&q6prmcc LPASS_CLK_ID_PRI_MI2S_IBIT LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
> +		clock-names = "mclk",
> +			      "bclk";
> +	};
> +};
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260728-topic-sm8x50-next-hdk-i2s-v1-0-2393a0fe4aa9@linaro.org?part=4