Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Wojciech Dubowik" <wojciech.dubowik@mt.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
	dri-devel@lists.freedesktop.org, robh@kernel.org
Subject: Re: [PATCH v7 2/3] dt-bindings: display: sn65dsi83: Add output data-lanes property
Date: Tue, 28 Jul 2026 12:29:24 +0000	[thread overview]
Message-ID: <20260728122924.AA9901F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260728122032.692482-3-wojciech.dubowik@mt.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `data-lanes` property requires exactly 4 items, breaking support for 18-bit (3-lane) LVDS configurations.
--

--- Patch [2]: [PATCH v7 2/3] dt-bindings: display: sn65dsi83: Add output data-lanes property ---
commit 9dc2b5a1e0c25c9fb7936d93599a48a919079b3b
Author: Wojciech Dubowik <Wojciech.Dubowik@mt.com>

dt-bindings: display: sn65dsi83: Add output data-lanes property

Add an optional output lvds data lanes property with two allowed values
for default and reversed layout.

> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> index e69b6343a8ebb..0eb3913acc9d4 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> @@ -125,6 +125,21 @@ $defs:
>                lanes in microvolts.
>              maxItems: 2
>  
> +          data-lanes:
> +            description:
> +              Array of physical LVDS data lane indexes
> +            oneOf:
> +              - items:
> +                  - const: 1
> +                  - const: 2
> +                  - const: 3
> +                  - const: 4
> +              - items:
> +                  - const: 4
> +                  - const: 3
> +                  - const: 2
> +                  - const: 1

[Severity: Medium]
Will this strict 4-item constraint break validation for 18-bit (3-lane) LVDS
configurations?

In dt-schema, specifying an items list automatically implies minItems equal to
the length of the list unless explicitly overridden. Without a minItems setting
defined here, the schema will reject arrays shorter than 4 elements, such as
data-lanes = <1 2 3> or <4 3 2>.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260728122032.692482-1-wojciech.dubowik@mt.com?part=2

  reply	other threads:[~2026-07-28 12:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28 12:20 [PATCH v7 0/3] drm/bridge: ti-sn65dsi83: Add reverse lvds lanes support Wojciech Dubowik
2026-07-28 12:20 ` [PATCH v7 1/3] drm/bridge: ti-sn65dsi83: Simplify error condition logic Wojciech Dubowik
2026-07-28 12:20 ` [PATCH v7 2/3] dt-bindings: display: sn65dsi83: Add output data-lanes property Wojciech Dubowik
2026-07-28 12:29   ` sashiko-bot [this message]
2026-07-28 12:20 ` [PATCH v7 3/3] drm/bridge: ti-sn65dsi83: Add reversed lvds lanes support Wojciech Dubowik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260728122924.AA9901F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=wojciech.dubowik@mt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox