Re: [PATCH net-next v8 5/9] net: mdio: realtek-rtl9300: Configure hardware polling during probing

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Direct return in `otto_emdio_probe` bypasses the error handling cleanup path, leaking the `priv` structure and leaving its mutex un-destroyed.
--

--- Patch [5]: [PATCH net-next v8 5/9] net: mdio: realtek-rtl9300: Configure hardware polling during probing ---
commit 128dff0b4abb09dc89d1f18960a479dceb85538d
Author: Markus Stockhausen <markus.stockhausen@gmx.de>

net: mdio: realtek-rtl9300: Configure hardware polling during probing

This commit adds support for configuring hardware polling on Realtek Otto
switches to prevent interference with firmware loading. It disables polling
for all ports at startup, and re-enables it when a PHY is attached.

Link: https://github.com/openwrt/openwrt/blob/main/target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c#L818
Link: https://lore.kernel.org/netdev/680696024a8648535ce6dee771fe4de67802e0e8.1769053496.git.daniel@makrotopia.org/

> diff --git a/drivers/net/mdio/mdio-realtek-rtl9300.c b/drivers/net/mdio/mdio-realtek-rtl9300.c
> index 9529f877248ba..0d5b9530e43b1 100644
> --- a/drivers/net/mdio/mdio-realtek-rtl9300.c
> +++ b/drivers/net/mdio/mdio-realtek-rtl9300.c

[ ... ]

> @@ -770,6 +821,10 @@ static int otto_emdio_probe(struct platform_device *pdev)
>  		goto err_out;
>  	}
>  
> +	err = otto_emdio_init_polling(priv);
> +	if (err)
> +		return err;

[Severity: Medium]
Does returning directly here leak the priv structure allocated earlier in
otto_emdio_probe() and bypass the error cleanup path? 

It looks like other error paths in this function use goto err_out to properly
clean up resources via kref_put. Would taking the err_out path be more
appropriate here?

> +
>  	platform_set_drvdata(pdev, priv);
>  
>  	err = otto_emdio_map_ports(dev);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727191559.19617-1-markus.stockhausen@gmx.de?part=5